Support unparsing Array plan to SQL string #13418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldmedal
commented
Nov 14, 2024
| match func_name { | ||
| "make_array" => self.make_array_to_sql(args), | ||
| "array_element" => self.array_element_to_sql(args), | ||
| // TODO: support for the construct and access functions of the `map` and `struct` types |
Contributor
Author
There was a problem hiding this comment.
Similar cases exist for map and struct. I'll file another issue for them.
alamb
approved these changes
Nov 15, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Makes sense to me -- thank you @goldmedal
| SUM(id) OVER (ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW) AS running_total | ||
| FROM person | ||
| GROUP BY GROUPING SETS ((id, first_name, last_name), (first_name, last_name), (last_name))"#, | ||
| "SELECT ARRAY[1, 2, 3]", |
Contributor
|
Thanks again @goldmedal |
Contributor
Author
|
Thanks @alamb |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11144.
Rationale for this change
DataFusion will plan the array construction and the elements' access to the corresponding scalar functions. If we don't handle those cases, they will be unparsed to
ast::Expr::ScalarFunctionwhich isn't a common SQL syntax.Array Construction
Elements accessing
This PR tries to allow the array SQL to do SQL-Plan-SQL roundtrip.
What changes are included in this PR?
make_arraytoast::Expr::Arrayarray_elementtoast::Expr::SubscriptAre these changes tested?
expr unit tests and SQL roundtrip tests.
Are there any user-facing changes?
no