Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Nov 1, 2024

Which issue does this PR close?

Rationale for this change

@dhegberg improved the write semantics in #13079 ❤️

While reviewing that PR I found a few more places where the documentation could be improved (aka take his great PR explanation and put in the code)

What changes are included in this PR?

Improve documentation and add a doc teset

Are these changes tested?

Yes by CI

Are there any user-facing changes?

Docs / examples

@alamb alamb added the documentation Improvements or additions to documentation label Nov 3, 2024
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Nov 5, 2024
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alamb really appreciate. I spend some painful hours back in the day trying to dig through those nested channels and coordinating demuxer

@comphead comphead merged commit 192079e into apache:main Nov 8, 2024
24 checks passed
@alamb
Copy link
Contributor Author

alamb commented Nov 8, 2024

Thanks @alamb really appreciate. I spend some painful hours back in the day trying to dig through those nested channels and coordinating demuxer

I think @dhegberg deserves much of the credit for the content 🏅

jayzhan211 pushed a commit to jayzhan211/datafusion that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants