Skip to content

WIP: Test increasing stack size as workaround for stack overflow errors in CI #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 58 commits into from
Closed

WIP: Test increasing stack size as workaround for stack overflow errors in CI #1001

wants to merge 58 commits into from

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Sep 14, 2021

Rationale:

This is a test PR to see if we can workaround the stack overflow bug that is hitting @Igosuki 's PR here: #910.

Changes

Implement suggestion in #910 (comment) to add some more stack size to CI test

Igosuki and others added 30 commits September 14, 2021 10:23
@Igosuki
Add avro as a datasource, file and table provider
7e14f91
@Igosuki
wip
0f940ab
@jorgecarleitao @Igosuki
Added support composite identifiers for struct type.
2ca7ccb
@jorgecarleitao @Igosuki
Fixed build.
fcbf43b
@Igosuki
cheat and add unions to valid composite column types
bae2f00
@Igosuki
Implement the AvroArrayReader
a352dad
@Igosuki
Add binary types
d42cdd1
@Igosuki
Enable Avro as a FileType
cbdc9c7
@Igosuki
Enable registering an avro table in the sql parsing
7d6078e
@Igosuki
Change package name for datafusion/avro
44cfa87
@Igosuki
Implement Avro datasource tests and fix avro_rs::Value resolution to …
6ef92d8 
…Arrow types
@Igosuki
Test for AvroExec::try_from_path
01cbb18
@Igosuki
external table avro test
537577a
@Igosuki
Basic schema conversion tests
75566d1
@Igosuki
Complete test for avro_to_arrow_reader on alltypes_dictionnary
7fdf233
@Igosuki
fix_stable: .rewind is 'unstable'
697e3a9
@Igosuki
Fix license files and remove the unused avro-converter crate
e1d6df8
@Igosuki
fix example test in avro_to_arrow
66a5901
@Igosuki
add avro_sql test to default workflow
9ea942c
@Igosuki
Adress clippies
84ee28a
@Igosuki
Enable avro as a valid datasource for client execution
9edac57
@Igosuki
Add avro to available logical plan nodes
e8a6206
@Igosuki
Add ToTimestampMillis as a scalar function in protos
45eac7c
@Igosuki
Allow Avro in PhysicalPlan nodes
b4340ac
@Igosuki
Remove remaining confusing references to 'json' in avro mod
408f759
@Igosuki
rename 'parquet' words in avro test and examples
f34b995
@Igosuki
Handle Union of nested lists in arrow reader
6ce0904
@Igosuki
test timestamp arrays
e1e40ef
@Igosuki
remove debug statement
1c79ffb
@Igosuki
Make avro optional
c96b781
Igosuki and others added 18 commits September 14, 2021 10:24
@Igosuki
Switch to Result instead of Option for resolve_string
8acf062
@Igosuki
Address missing clippy warning should_implement_trait in arrow_to_avr…
65c9b9e 
…o/reader
@Igosuki
Add fmt display implementation for AvroExec
1668b96
@Igosuki
ci: fix cargo sql run example, use datafusion/avro feature instead of…
c9218e2 
… 'avro'
@Igosuki
license: missing license file for avro_to_arrow/schema.rs
be09a64
@Igosuki
only run avro datasource tests if features have 'avro'
68df268
@Igosuki
refactor: rename infer_avro_schema_from_reader to read_avro_schema_fr…
09c4ecb 
…om_reader
@Igosuki
Pass None as props to avro schema schema_to_field_with_props until fu…
94b9dcb 
…rther notice
@Igosuki
Change schema inferance to FixedSizeBinary(16) for Uuid
a03a3c2
@Igosuki
schema: prefix metadata coming from avro with 'avro'
405c63a
@Igosuki
make num traits optional and part of the avro feature flag
291637a
@Igosuki
Fix avro schema tests regarding external props
00f109c
@Igosuki
split avro physical plan test feature wise and add a non-implemented …
ea31e02 
…test
@Igosuki
submodule: switch back to apache/arrow-testing
a264858
@Igosuki
fix_test: columns are now prefixed in the plan
c62d931
@Igosuki
avro_test: fix clippy warning cmp-owned
aa45189
@Igosuki
avro: move statistics to the physical plan
0b746db
@alamb
Use larger stack for tests on CI
a709fd9
@github-actions github-actions bot added ballista sql SQL Planner labels Sep 14, 2021
@Dandandan
Copy link
Contributor

@alamb Opening another experiment in #1003

@alamb
Copy link
Contributor Author

alamb commented Sep 15, 2021

this does not appear to help

@alamb alamb closed this Sep 15, 2021
@alamb alamb deleted the alamb/test_stack_workaround branch September 15, 2021 11:01
andygrove pushed a commit to andygrove/datafusion that referenced this pull request Jan 31, 2025
@kazuyukitanimura
chore: Bump arrow-rs to 53.1.0 and datafusion (apache#1001)
e1e5483 
## Which issue does this PR close?

## Rationale for this change

Arrow-rs 53.1.0 includes performance improvements 

## What changes are included in this PR?

Bumping arrow-rs to 53.1.0 and datafusion to a revision

## How are these changes tested?

existing tests
unkloud pushed a commit to unkloud/datafusion that referenced this pull request Mar 23, 2025
@kazuyukitanimura
chore: Bump arrow-rs to 53.1.0 and datafusion (apache#1001)
591f45a 
## Which issue does this PR close?

## Rationale for this change

Arrow-rs 53.1.0 includes performance improvements 

## What changes are included in this PR?

Bumping arrow-rs to 53.1.0 and datafusion to a revision

## How are these changes tested?

existing tests
H0TB0X420 pushed a commit to H0TB0X420/datafusion that referenced this pull request Oct 7, 2025
@timsaucer
Apply import ordering in ruff check (apache#1001)
78e72c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

sql SQL Planner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alamb @Dandandan @Igosuki @jorgecarleitao