Potential performance regression with comparisions to scalar values

[alamb]

Describe the bug

There is concern changes in this PR will cause regression (as it may convert some numbers to Decimal128 rather than more efficient Integer)

• fix(expr-common): Coerce to Decimal(20, 0) when combining UInt64 with signed integers #14223

However, it is not clear (to me at least) exactly the implications of the change

@berkaysynnada has found a potential performance regression, as described here: #14223 (comment)

cc @nuno-faria @jonahgao and @berkaysynnada and @ozankabak

To Reproduce

No response

Expected behavior

I want to make sure that this issue is resolved before we release datafusion 45.0.0, so filing this ticket so we don't forget

Examples of ways to resolve the ticket:

• Decide the change was fine
• Revert the changes
• Others

Additional context

No response

[alamb]

I ran benchmarks with / without this change and did not see any noticable performance difference. See details here

• Revert "fix(expr-common): Coerce to Decimal(20, 0) when combining UInt64 with signed integers (#14223)" #14292

I also created a PR with some tests that show the practical impact of this PR on comparisons (I think it is minimal). See

• Add more tests showing coercing behavior with literals #14270

So in other words I would be inclined to close this ticket without further changes given what I currently know

[berkaysynnada]

https://github.com/synnada-ai/datafusion-upstream/tree/benchmark-cast

The last commit shows the simplest case that is regressed