Skip to content

Update expected output for coalsece short-circuit #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2025
Merged

Update expected output for coalsece short-circuit #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions data/sqlite/random/expr/slt_good_0.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20520,10 +20520,10 @@ SELECT ALL + 23 / 28 * - - COUNT ( + + 10 ) * + 12
----
0

# Datafusion - Datafusion expected results:
# Datafusion - Expected - 0
query error DataFusion error: Arrow error: Divide by zero error
query I rowsort label-3927
Copy link
Contributor Author

@alamb alamb Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given these are in files "good" I think they should be succeeding

I confirmed (for this one) that this is the answer that postgres gives

postgres=# SELECT + CAST ( - 13 AS INTEGER ) / COALESCE ( - + 14, + - NULLIF ( - COUNT ( * ), 19 * - - NULLIF ( 12, + MIN ( ALL - - ( + - 11 ) ) ) / + - 4 + - 84 + + 36 - - 57 + - + 68 * NULLIF ( + 57, + 45 ) ) * + 24 / CAST ( - 0 AS INTEGER ) / + 90, - 93 ) col0;
 col0
------
    0
(1 row)

SELECT + CAST ( - 13 AS INTEGER ) / COALESCE ( - + 14, + - NULLIF ( - COUNT ( * ), 19 * - - NULLIF ( 12, + MIN ( ALL - - ( + - 11 ) ) ) / + - 4 + - 84 + + 36 - - 57 + - + 68 * NULLIF ( + 57, + 45 ) ) * + 24 / CAST ( - 0 AS INTEGER ) / + 90, - 93 ) col0
----
0

query I rowsort
SELECT ALL - 41 AS col2
Expand Down
20 changes: 10 additions & 10 deletions data/sqlite/random/expr/slt_good_10.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37288,11 +37288,11 @@ SELECT DISTINCT 87 * + 75 * - 22 AS col0
----
-143550

# Datafusion - Datafusion expected results:
# Datafusion - Expected - -29
Copy link
Contributor Author

@alamb alamb Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is actually kind of cool -- @Omega359 's script left in the expected results, so we can see that after this change DataFusion is now actually generating the expected results

Copy link
Contributor Author

@alamb alamb Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this case,

-29
-900

# Datafusion - Expected - -900
query error DataFusion error: Arrow error: Divide by zero error
query II rowsort label-7077
SELECT ALL 10 + COALESCE ( + - 39, - + ( COUNT ( * ) ) * + + MAX ( DISTINCT - 64 ) * + ( + 56 ) / + 0 ), - 60 * - - 15 AS col2
----
-29
-900

query I rowsort
SELECT - COALESCE ( CASE 20 WHEN - 1 THEN + 14 * - + 5 + 29 ELSE NULL END, + 78 ) AS col2
Expand Down Expand Up @@ -44097,10 +44097,10 @@ SELECT ALL CAST ( NULL AS INTEGER ) + 53 * 66 * - + COUNT ( * ) * + - 26 + 19
----
NULL

# Datafusion - Datafusion expected results:
# Datafusion - Expected - -45
query error DataFusion error: Arrow error: Divide by zero error
query I rowsort label-8381
SELECT - - COALESCE ( - 45, NULLIF ( + 94, + - 92 - - - 61 + 19 * COUNT ( * ) * + - 36 * - 64 / - + 67 * ( + 58 ) / COUNT ( DISTINCT - CAST ( NULL AS INTEGER ) ) ) * + 59, + 63 )
----
-45

query I rowsort label-8382
SELECT - - 84 * - 45 * - - CASE - 72 WHEN 91 THEN COUNT ( * ) WHEN + 31 THEN NULL ELSE NULL END AS col0
Expand Down Expand Up @@ -49579,10 +49579,10 @@ SELECT - 68 - 41
----
-109

# Datafusion - Datafusion expected results:
# Datafusion - Expected - NULL
query error DataFusion error: Arrow error: Divide by zero error
query I rowsort label-9427
SELECT CASE - 92 WHEN - - 20 * - 46 + - - 8 THEN - 70 WHEN + ( - 2 ) THEN 73 - + - CAST ( 51 AS INTEGER ) + + + 53 WHEN - 59 THEN CAST ( ( 23 ) AS INTEGER ) * 82 WHEN MIN ( 80 ) / COALESCE ( - 4, - COUNT ( * ) / 0 ) + 72 / 9 THEN 36 * 81 + + 0 * 78 END + 43 AS col2
----
NULL

query I rowsort label-9428
SELECT CAST ( NULL AS INTEGER ) - + - COALESCE ( 4, MIN ( 32 ) ) + MAX ( - 73 ) AS col0
Expand Down
8 changes: 3 additions & 5 deletions data/sqlite/random/expr/slt_good_100.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14291,12 +14291,10 @@ SELECT ALL - 3 * CASE COUNT ( ALL 77 ) WHEN + + 69 + + + 75 + + 10 THEN 29 / 18
----
NULL

# Postgresql - Postgres error: db error: ERROR: division by zero
# Datafusion - Datafusion expected results:
# Datafusion - Expected - -59
skipif postgres
query error DataFusion error: Arrow error: Divide by zero error
query I rowsort label-2709
SELECT ALL + 59 * - COALESCE ( COUNT ( ALL + 82 ), + - 11 * 98 / 0 + COUNT ( * ) + - - 11 + + - 96 + - ( + MIN ( DISTINCT 82 ) ) * + 86 * + 11 ) + - + 0
----
-59

query II rowsort
SELECT - - 71 AS col0, - 48 + - 75
Expand Down
6 changes: 3 additions & 3 deletions data/sqlite/random/expr/slt_good_101.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33945,10 +33945,10 @@ SELECT ALL - SUM ( 31 ) AS col1
----
-31

# Datafusion - Datafusion expected results:
# Datafusion - Expected - 48
query error DataFusion error: Arrow error: Divide by zero error
query I rowsort label-6449
SELECT ALL COUNT ( * ) - COALESCE ( - 47, - - 92 + - MAX ( 52 ) / - - CAST ( + - 0 AS INTEGER ) + + 50 )
----
48

query II rowsort label-6450
SELECT COUNT ( * ) * + 48, 64 AS col2
Expand Down
12 changes: 6 additions & 6 deletions data/sqlite/random/expr/slt_good_102.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23926,10 +23926,10 @@ SELECT 18 / - + 37 + + 0
----
0

# Datafusion - Datafusion expected results:
# Datafusion - Expected - 11
query error DataFusion error: Arrow error: Divide by zero error
query I rowsort label-4533
SELECT COUNT ( * ) * + COALESCE ( NULLIF ( + + 11, + CAST ( NULL AS INTEGER ) ), - - 93, + + 92 / - + 82 * - MIN ( ( + 32 ) ) / - 0 + 61, - 69 )
----
11

query I rowsort
SELECT + 6 + + + 34
Expand Down Expand Up @@ -51534,10 +51534,10 @@ SELECT COUNT ( ALL 83 ) * - MAX ( 76 ) * 25 * - 92 + COALESCE ( + 70 + - COUNT (
----
174884

# Datafusion - Datafusion expected results:
# Datafusion - Expected - 3920
query error DataFusion error: Arrow error: Divide by zero error
query I rowsort label-9785
SELECT COALESCE ( + ( COALESCE ( + 56, + MIN ( + 30 ) - ( ( + NULLIF ( - COUNT ( * ), + 14 / ( - 15 / + 55 ) ) ) ) ) ), COALESCE ( + 88, 84 * - 17 ) + 71 ) * 70
----
3920

query I rowsort
SELECT 10 * + 36
Expand Down
8 changes: 4 additions & 4 deletions data/sqlite/random/expr/slt_good_104.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3691,11 +3691,11 @@ SELECT DISTINCT + 57 * COUNT ( * )
----
57

# Datafusion - Datafusion expected results:
# Datafusion - Expected - -1750
# Datafusion - Expected - -70
query error DataFusion error: Arrow error: Divide by zero error
query II rowsort label-687
SELECT - 35 * + 50 AS col0, COALESCE ( - + 70, + 20 / - 71 / - 0, - - 12 ) * MIN ( 1 )
----
-1750
-70

query I rowsort label-688
SELECT - MIN ( + 75 ) * + 8 + + 76 * 50
Expand Down
18 changes: 9 additions & 9 deletions data/sqlite/random/expr/slt_good_105.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2698,10 +2698,10 @@ SELECT + ( - 1 ) AS col0
----
-1

# Datafusion - Datafusion expected results:
# Datafusion - Expected - 38
query error DataFusion error: Arrow error: Divide by zero error
query I rowsort
SELECT + NULLIF ( + + ( + 38 ), - + COALESCE ( + 11, + 34 / - 0, - 63 ) - + 47 + 12 * - + 7 )
----
38

query I rowsort label-503
SELECT ALL + MIN ( + 96 )
Expand Down Expand Up @@ -19836,10 +19836,10 @@ SELECT DISTINCT + + COUNT ( - 26 ) AS col2
----
1

# Datafusion - Datafusion expected results:
# Datafusion - Expected - -41
query error DataFusion error: Arrow error: Divide by zero error
query I rowsort label-3760
SELECT - 71 - - 46 * 29 / - COALESCE ( ( COALESCE ( 77, - COUNT ( * ) / - 0, - 75 ) ), + COUNT ( * ) ) + MIN ( ALL + 47 )
----
-41

query I rowsort label-3761
SELECT - MIN ( + 11 ) * - - 37 * + 95
Expand Down Expand Up @@ -22635,10 +22635,10 @@ SELECT 39 * + 97 * 8 + - + 26 * + 41
----
29198

# Datafusion - Datafusion expected results:
# Datafusion - Expected - -1329
query error DataFusion error: Arrow error: Divide by zero error
query I rowsort label-4296
SELECT COALESCE ( + + 28, + 71 + 63 * - MAX ( DISTINCT - 71 ) * + COUNT ( * ), - 82, + 2 - SUM ( 88 ), 58 / - NULLIF ( + COUNT ( * ) / 65, 99 + 62 ) ) + - 59 * 23 AS col2
----
-1329

query I rowsort label-4297
SELECT ALL - CAST ( + + 34 AS INTEGER ) AS col2
Expand Down
12 changes: 6 additions & 6 deletions data/sqlite/random/expr/slt_good_106.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27502,10 +27502,10 @@ SELECT + 97, ( - + COUNT ( * ) ) AS col1
97
-1

# Datafusion - Datafusion expected results:
# Datafusion - Expected - 75
query error DataFusion error: Arrow error: Divide by zero error
query I rowsort label-5238
SELECT - NULLIF ( + 24, 53 ) + - COALESCE ( + 40, + 7 / 55 / + + 0 ) + + 43 + + 96
----
75

query I rowsort
SELECT ALL + ( 89 ) AS col1
Expand Down Expand Up @@ -44430,10 +44430,10 @@ SELECT - CAST ( + 77 AS INTEGER ) * + 73 AS col2, 38 * + 19 * - 57 col0
-5621
-41154

# Datafusion - Datafusion expected results:
# Datafusion - Expected - -900
query error DataFusion error: Arrow error: Divide by zero error
query I rowsort label-8457
SELECT ALL + 2 + + COALESCE ( - NULLIF ( - - 41, 83 * - CASE + 0 WHEN + 30 + - 96 THEN - 16 + - 11 + + MIN ( ALL - 73 ) / 72 / - - 18 WHEN + 35 THEN + - 98 + + + 89 END + - 14 + - - 12 + - 79 + - + 23 * + 52 ), + 70 / + + 0 ) * + + 22
----
-900

query I rowsort
SELECT ALL + 29 * - - 48 AS col1
Expand Down
6 changes: 3 additions & 3 deletions data/sqlite/random/expr/slt_good_107.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8427,10 +8427,10 @@ SELECT SUM ( - - 1 ) + + CAST ( NULL AS INTEGER ) - 38 + + - 12 * + - 37 * SUM (
----
NULL

# Datafusion - Datafusion expected results:
# Datafusion - Expected - 2530
query error DataFusion error: Arrow error: Divide by zero error
query I rowsort label-1604
SELECT ALL 22 + - CAST ( + + COALESCE ( - 69, + AVG ( DISTINCT + 99 ) / 80, 30 + - COALESCE ( 3, + 51, + - 7 + NULLIF ( + 51, + 48 * - CASE - 44 WHEN - 56 + 40 THEN NULL WHEN - 53 / + - CAST ( - + 0 AS INTEGER ) / + + 34 THEN NULL ELSE - + 63 END ) ) ) AS INTEGER ) * - CASE + COUNT ( * ) WHEN - 98 * - CAST ( NULL AS INTEGER ) THEN NULL ELSE - - 41 / + ( + 30 ) + - 92 - - + 90 END + 44 * 54 + 63 AS col0
----
2530

# Datafusion - Datafusion expected results:
# Datafusion - Expected - 38
Expand Down
12 changes: 6 additions & 6 deletions data/sqlite/random/expr/slt_good_108.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38979,10 +38979,10 @@ SELECT - CASE + COUNT ( - + 71 ) WHEN - - COUNT ( * ) + 71 + + 62 * + COUNT ( *
----
-1890

# Datafusion - Datafusion expected results:
# Datafusion - Expected - 86
query error DataFusion error: Arrow error: Divide by zero error
query I rowsort label-7425
SELECT ALL + + COALESCE ( - - 86, - 45 + - - MAX ( 49 ), - - 81 / - 0 + - + 47 + + - 65 ) AS col1
----
86

query II rowsort label-7426
SELECT + - CAST ( NULL AS INTEGER ) / + 95 * 83, 55 AS col0
Expand Down Expand Up @@ -39307,10 +39307,10 @@ SELECT + 10, COUNT ( DISTINCT - 82 ) AS col2
10
1

# Datafusion - Datafusion expected results:
# Datafusion - Expected - -2052
query error DataFusion error: Arrow error: Divide by zero error
query I rowsort label-7486
SELECT ALL - COALESCE ( - - 57, 1 * - + 82, COUNT ( * ) / + 58 / 0 + - COUNT ( * ) + - 3 ) * + 36
----
-2052

query I rowsort
SELECT 80 * - 21
Expand Down
12 changes: 6 additions & 6 deletions data/sqlite/random/expr/slt_good_110.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17069,10 +17069,10 @@ SELECT CAST ( NULL AS INTEGER ) * + 24 / + 75
----
NULL

# Datafusion - Datafusion expected results:
# Datafusion - Expected - -89
query error DataFusion error: Arrow error: Divide by zero error
query I rowsort label-3234
SELECT - COALESCE ( CAST ( 89 AS INTEGER ), - NULLIF ( + 29, - 22 / MIN ( ALL - 11 / 75 ) ) )
----
-89

query I rowsort label-3235
SELECT 44 - + SUM ( - 27 ) * 4
Expand Down Expand Up @@ -27703,10 +27703,10 @@ SELECT 88 + 69
----
157

# Datafusion - Datafusion expected results:
# Datafusion - Expected - 1810
query error DataFusion error: Arrow error: Divide by zero error
query I rowsort label-5267
SELECT - NULLIF ( - + 40, 92 ) * 43 - + - COALESCE ( 90, + 61, + 2 / 19 / 0 * + + 44, 19 / - 6 * - + 23 )
----
1810

query I rowsort
SELECT - 77 + - 18
Expand Down
12 changes: 6 additions & 6 deletions data/sqlite/random/expr/slt_good_111.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25200,10 +25200,10 @@ SELECT DISTINCT - 23 + + CASE 75 WHEN 89 / + ( + CASE + 21 WHEN + 26 + - CAST (
----
-168

# Datafusion - Datafusion expected results:
# Datafusion - Expected - -1
query error DataFusion error: Arrow error: Divide by zero error
query I rowsort label-4804
SELECT ALL - COALESCE ( + MIN ( DISTINCT + - COALESCE ( - + 1, + 80 / + + 0 + 53, - - ( + ( CAST ( + 65 AS INTEGER ) ) ) / 70 + 41 ) ), - 80 )
----
-1

query II rowsort
SELECT ALL - 94 AS col2, + 5 AS col0
Expand Down Expand Up @@ -30556,10 +30556,10 @@ SELECT - 27 + ( - 72 ) col0
----
-99

# Datafusion - Datafusion expected results:
# Datafusion - Expected - 4281
query error DataFusion error: Arrow error: Divide by zero error
query I rowsort label-5818
SELECT + MAX ( DISTINCT - - 81 ) * + SUM ( ALL + 52 ) + COALESCE ( + 69, + 94, + ( - 40 ) / - 0 )
----
4281

query I rowsort label-5819
SELECT + SUM ( - 37 ) AS col2
Expand Down
14 changes: 7 additions & 7 deletions data/sqlite/random/expr/slt_good_112.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4996,10 +4996,10 @@ SELECT DISTINCT + 26 - - 58 AS col0
----
84

# Datafusion - Datafusion expected results:
# Datafusion - Expected - -12
query error DataFusion error: Arrow error: Divide by zero error
query I rowsort label-940
SELECT ALL - COALESCE ( + 12, - 86 + + + MAX ( DISTINCT - - 99 ) + 7 + + 9 * + - 96, NULLIF ( + - CASE + 9 WHEN CASE 50 WHEN + 13 THEN - 78 END * + 55 THEN - 54 * + + ( + COUNT ( DISTINCT 7 ) ) END, 62 * - - COUNT ( * ) / + 0 + + COUNT ( * ) - - + COUNT ( * ) ) * - 7 ) AS col1
----
-12

query II rowsort label-941
SELECT - + 55 * - - COUNT ( * ) AS col2, 24 + - + 54 AS col0
Expand Down Expand Up @@ -9000,11 +9000,11 @@ SELECT ALL ( + 49 ) - COUNT ( * ) + - 95 col2
----
-47

# Datafusion - Datafusion expected results:
# Datafusion - Expected - -92
# Datafusion - Expected - 19
query error DataFusion error: Arrow error: Divide by zero error
query II rowsort label-1705
SELECT ALL - 92 AS col1, ( 19 ) + - COALESCE ( + 0, - + 27 + 47 * - 58, + 53 / - 0 ) col0
----
-92
19

query I rowsort
SELECT - 90 * - 73 * 79 AS col0
Expand Down
12 changes: 6 additions & 6 deletions data/sqlite/random/expr/slt_good_113.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44725,10 +44725,10 @@ SELECT 9 * + + COUNT ( 96 ) AS col0
----
9

# Datafusion - Datafusion expected results:
# Datafusion - Expected - 0
query error DataFusion error: Arrow error: Divide by zero error
query I rowsort label-8501
SELECT COALESCE ( + + COUNT ( * ), - CAST ( + 3 AS INTEGER ), 72 / + 0 + + 63 + - 51 ) / + 33 AS col2
----
0

query I rowsort
SELECT - + 86 col1
Expand Down Expand Up @@ -51194,10 +51194,10 @@ SELECT + 53 + + + 52 * - 50 AS col0
----
-2547

# Datafusion - Datafusion expected results:
# Datafusion - Expected - -48
query error DataFusion error: Arrow error: Divide by zero error
query I rowsort label-9730
SELECT DISTINCT - COALESCE ( - - 57, MAX ( ALL - + 87 ) / 0 + + 93 * - 93 ) + - 7 + - 53 / + ( + + 86 ) * SUM ( + 8 ) + + 16
----
-48

query I rowsort label-9731
SELECT ALL CAST ( NULL AS INTEGER ) + - 81 AS col1
Expand Down
6 changes: 3 additions & 3 deletions data/sqlite/random/expr/slt_good_116.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6351,10 +6351,10 @@ SELECT + + 0 * + - 2 AS col0
----
0

# Datafusion - Datafusion expected results:
# Datafusion - Expected - -84
query error DataFusion error: Arrow error: Divide by zero error
query I rowsort label-1199
SELECT ALL CASE COALESCE ( + 92, - + NULLIF ( - MAX ( ALL + + 46 ), ( - 85 ) + + COALESCE ( 54, + COUNT ( * ) * + - 42 ) ) * ( + - COUNT ( * ) ), + + 66 - + 75 * - COUNT ( * ) + ( 64 ) * + - COUNT ( * ), + 91 + COUNT ( * ) + + COALESCE ( + 2, - CAST ( NULL AS INTEGER ) * + - 21 + 39 ) / + 0 * - - 85 ) WHEN - 23 THEN NULL WHEN + - 51 THEN + COUNT ( * ) ELSE - 84 END
----
-84

query I rowsort label-1200
SELECT DISTINCT + ( - - 56 ) / + 89 + ( + 38 ) AS col0
Expand Down
6 changes: 3 additions & 3 deletions data/sqlite/random/expr/slt_good_118.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16422,10 +16422,10 @@ SELECT ALL - + ( + 40 ) col1
----
-40

# Datafusion - Datafusion expected results:
# Datafusion - Expected - 8194
query error DataFusion error: Arrow error: Divide by zero error
query I rowsort label-3130
SELECT + 94 * 88 + - COALESCE ( 78, 15 / MIN ( + 0 ), - 21, - 46 ) col0
----
8194

query II rowsort
SELECT DISTINCT - - 93 col2, + 8
Expand Down
Loading