Skip to content

Conversation

@jdye64
Copy link
Contributor

@jdye64 jdye64 commented Jun 13, 2023

This closes: #895

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5260946891

  • 5 of 9 (55.56%) changed or added relevant lines in 5 files are covered.
  • 140 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 86.942%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/dialect/duckdb.rs 1 2 50.0%
src/dialect/generic.rs 1 2 50.0%
src/dialect/mod.rs 1 2 50.0%
src/dialect/postgresql.rs 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
src/lib.rs 140 11.74%
Totals Coverage Status
Change from base Build 5210390017: -0.06%
Covered Lines: 14874
Relevant Lines: 17108

💛 - Coveralls

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andygrove
Copy link
Member

cc @jimexist @alamb

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jdye64

@alamb alamb merged commit 2296de2 into apache:main Jun 15, 2023
serprex pushed a commit to serprex/sqlparser-rs that referenced this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modify Dialect trait to include supports_group_by_expr function

4 participants