-
Notifications
You must be signed in to change notification settings - Fork 251
chore: Prepare for DataFusion 48.0.0 #1710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
e863fb0
ae483bb
ee13ee0
6907d69
b3673e8
58fe4ee
fbc4948
8d77b36
61054f7
8dc5c41
a661700
501030e
56a20d1
a3e3f2d
aeede31
2b2b085
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -141,7 +141,7 @@ impl ExecutionPlan for ShuffleWriterExec { | |
| } | ||
|
|
||
| fn statistics(&self) -> Result<Statistics> { | ||
| self.input.statistics() | ||
| self.input.partition_statistics(None) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. rename to
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes |
||
| } | ||
|
|
||
| fn properties(&self) -> &PlanProperties { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -78,8 +78,8 @@ pub(crate) fn init_datasource_exec( | |
| )) | ||
| }); | ||
|
|
||
| if let (Some(filter), Some(data_schema)) = (cnf_data_filters, &data_schema) { | ||
| parquet_source = parquet_source.with_predicate(Arc::clone(data_schema), filter); | ||
| if let Some(filter) = cnf_data_filters { | ||
| parquet_source = parquet_source.with_predicate(filter); | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There were changes to the predicate push-down API |
||
| } | ||
| } | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,6 +20,7 @@ | |
| use crate::parquet::parquet_support::{spark_parquet_convert, SparkParquetOptions}; | ||
| use arrow::array::{new_null_array, RecordBatch, RecordBatchOptions}; | ||
| use arrow::datatypes::{Schema, SchemaRef}; | ||
| use datafusion::common::ColumnStatistics; | ||
| use datafusion::datasource::schema_adapter::{SchemaAdapter, SchemaAdapterFactory, SchemaMapper}; | ||
| use datafusion::physical_plan::ColumnarValue; | ||
| use std::sync::Arc; | ||
|
|
@@ -226,6 +227,13 @@ impl SchemaMapper for SchemaMapping { | |
| let record_batch = RecordBatch::try_new_with_options(schema, cols, &options)?; | ||
| Ok(record_batch) | ||
| } | ||
|
|
||
| fn map_column_statistics( | ||
| &self, | ||
| _file_col_statistics: &[ColumnStatistics], | ||
| ) -> datafusion::common::Result<Vec<ColumnStatistics>> { | ||
| Ok(vec![]) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this unused or just placeholder...?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Column statistics are not used in Comet |
||
| } | ||
| } | ||
|
|
||
| #[cfg(test)] | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We now have to provide Field instead of DataType