Skip to content

Fix for initial startup time (#131) #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix for initial startup time (#131) #132

wants to merge 2 commits into from

Conversation

spoyd
Copy link

@spoyd spoyd commented Feb 6, 2019

Overview

Initial startup time (first execution) on some docker hosts is >50 seconds. This is caused by updating the ownership of more than 1600 files during the first execution of an instance of this container. These files are all static in the container and could be modified at container build time instead of at runtime.

Testing recommendations

Startup time for the container should be < 3 seconds.

GitHub issue number

#131

Related Pull Requests

n/a

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;

@wohali
Copy link
Member

wohali commented Feb 6, 2019

@kocolosk please review?

@kocolosk
Copy link
Member

kocolosk commented Feb 6, 2019

I could have sworn we already made this change ...

@kocolosk
Copy link
Member

kocolosk commented Feb 6, 2019

Ah, no - the changes in #110 were scoped to the docker-entrypoint.sh file. I will review.

@wohali
Copy link
Member

wohali commented Mar 11, 2019

@kocolosk poke. this missed the 2.3.1 image but could land in 2.4.0.

@spoyd
Copy link
Author

spoyd commented Mar 26, 2019

@wohali What do I need to do to complete the checklist and get this accepted?

@kocolosk
Copy link
Member

@spoyd I will get back to you in < 24h if anything is needed, sorry for the delay

@kocolosk
Copy link
Member

@spoyd looks good and correct - sorry this took so long to review. Can you make the same change in the dev/Dockerfile and most importantly the 2.3.1/Dockerfile (which didn't exist when you filed this PR) so we make sure it gets carried forward to new official image builds? Then I'm happy to merge.

@TeamLinux01 TeamLinux01 mentioned this pull request Apr 29, 2019
3 tasks
@wohali
Copy link
Member

wohali commented Apr 29, 2019

@spoyd ping, are you able to clean up this PR please? Thanks. See @kocolosk 's comment above.

@wohali
Copy link
Member

wohali commented Apr 30, 2019

Closing in favour of #144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants