Skip to content

Inline browser_parser into Api #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2025
Merged

Conversation

raphinesse
Copy link
Contributor

Motivation and Context

Reduce (unused) code.

Description

  • Remove unused stuff from browser_parser
  • Inline remaining two methods from browser_parser into Api

This removes the property parser from Api instances. AFAIK this prop is not documented, so I'd consider it private. But if we would consider it public, this PR would be a major change.

Testing

I ran npm t

@raphinesse raphinesse requested a review from erisu June 3, 2020 13:48
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2020

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.75%. Comparing base (8938584) to head (a46969f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   93.75%   93.75%           
=======================================
  Files           2        2           
  Lines          32       32           
=======================================
  Hits           30       30           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erisu
Copy link
Member

erisu commented Jul 17, 2025

I rebased the PR with current main branch.

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erisu erisu added this to the 8.0.0 milestone Jul 17, 2025
@erisu erisu merged commit be8f21b into apache:master Jul 17, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants