Add UUID field for LDAP configuration #11462
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaanHoogland
approved these changes
Aug 18, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #11462 +/- ##
=========================================
Coverage 17.35% 17.35%
- Complexity 15230 15233 +3
=========================================
Files 5886 5886
Lines 525685 525697 +12
Branches 64159 64159
=========================================
+ Hits 91247 91260 +13
Misses 424138 424138
+ Partials 10300 10299 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
| } | ||
|
|
||
| public LdapConfigurationVO(final String hostname, final int port, final Long domainId) { | ||
| this.hostname = hostname; | ||
| this.port = port; | ||
| this.domainId = domainId; | ||
| this.uuid = UUID.randomUUID().toString(); |
There was a problem hiding this comment.
shouldn’t this be read from the DB somehow?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?