Skip to content

Conversions: resolveExecutionProfile only when needed #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversions: resolveExecutionProfile only when needed #1622

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ccdf9e
Conversions: resolveExecutionProfile only when needed
chibenwa Dec 3, 2022
2f765b3
Merge branch '4.x' into conversions
chibenwa Dec 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions core/src/main/java/com/datastax/oss/driver/internal/core/cql/Conversions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,17 +535,18 @@ public static CoordinatorException toThrowable(

public static boolean resolveIdempotence(Request request, InternalDriverContext context) {
Boolean requestIsIdempotent = request.isIdempotent();
DriverExecutionProfile executionProfile = resolveExecutionProfile(request, context);
return (requestIsIdempotent == null)
? executionProfile.getBoolean(DefaultDriverOption.REQUEST_DEFAULT_IDEMPOTENCE)
? resolveExecutionProfile(request, context)
.getBoolean(DefaultDriverOption.REQUEST_DEFAULT_IDEMPOTENCE)
: requestIsIdempotent;
}

public static Duration resolveRequestTimeout(Request request, InternalDriverContext context) {
DriverExecutionProfile executionProfile = resolveExecutionProfile(request, context);
return request.getTimeout() != null
? request.getTimeout()
: executionProfile.getDuration(DefaultDriverOption.REQUEST_TIMEOUT);
Duration timeout = request.getTimeout();
return timeout != null
? timeout
: resolveExecutionProfile(request, context)
.getDuration(DefaultDriverOption.REQUEST_TIMEOUT);
}

public static RetryPolicy resolveRetryPolicy(Request request, InternalDriverContext context) {
Expand Down