Optimizations for TypeSafeDriverConfig #1616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a typical applicative workload, 0.53% of CPU is spend resolving configuration profiles. By getting the profile first and failing if it is null we can easily cut that in half.
We could easily get a dedicated field for the default profile thus avoiding recurring maps lookups.
absurdfarce
approved these changes
Nov 15, 2022
Contributor
absurdfarce
left a comment
absurdfarce
left a comment
There was a problem hiding this comment.
Looks pretty good to me. A couple fairly small things I'd like to get @chibenwa 's feedback on but none of it is essential; I'd be fine putting this in as it stands.
...rc/main/java/com/datastax/oss/driver/internal/core/config/typesafe/TypesafeDriverConfig.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/datastax/oss/driver/internal/core/config/typesafe/TypesafeDriverConfig.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/datastax/oss/driver/internal/core/config/typesafe/TypesafeDriverConfig.java
Show resolved
Hide resolved
chibenwa
force-pushed
the
default-conf
branch
from
4b950d6 to
45b77dc
Compare
Contributor
|
Looks good! Thanks (again) @chibenwa! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small but easy gains...