chore(components): fix endless loops

[squakez]

Description

Target

• I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

• If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

• I checked that each commit in the pull request has a meaningful subject line and body.

• I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

[github-actions]

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

• First-time contributors require MANUAL approval for the GitHub Actions to run

• You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

• You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

• Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

• ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

[squakez]

@oscerd this one seems to be the only reason why the thread is interrupted. Can you double check?

[davsclaus]

those forever loops should also check if the camel consumer has isRunAllowed so they can nicely exit when camel is shutting down or if you stop the route etc

[squakez]

those forever loops should also check if the camel consumer has isRunAllowed so they can nicely exit when camel is shutting down or if you stop the route etc

do you suggest to use that condition in the while loop as well? do you have any example to share by any chance? thanks!

[davsclaus]

This PR is fine.

About the endless while loop (true) then another PR can attempt to correct this. So when Camel is shutting down the consumer is being called in the doStop method. And there it should stop its resources and threads etc. So those forever loops seems to not be stopped gracefully and rely on some thread interrupt that is messy and ugly.

Try to do a

 git grep "while (isRunAllowed()"

Or combinations of that. There are some components that does this.

[squakez]

This PR is fine.

About the endless while loop (true) then another PR can attempt to correct this. So when Camel is shutting down the consumer is being called in the doStop method. And there it should stop its resources and threads etc. So those forever loops seems to not be stopped gracefully and rely on some thread interrupt that is messy and ugly.

Try to do a

 git grep "while (isRunAllowed()"

Or combinations of that. There are some components that does this.

Okey, thanks for the hint. I will try to have a look and include in this PR if I can, otherwise I'll create a Jira issue to keep track of such an enhancement.

[squakez]

@davsclaus @oscerd this should be good now. I've maintained the running flag in the pulsar, just in case the interrupted exception was not caught at a higher level. We probably could have removed it though.

[davsclaus]

LGTM

[oscerd]

Thx. LGTM