Skip to content

Conversation

jecsand838
Copy link
Contributor

This adds a new skippable_types.avro file which will be used to test arrow-avro again files with zero byte records..

Here's the python script used to generate the new Avro file: https://gist.github.com/jecsand838/82d9874a5f9be8a636dcd49ad9b8e237

Part of apache/arrow-rs#4886

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jecsand838 -- any chance we can reduce the size of this PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notice this file is 3.1KB -- and given this repo is widely used I wonder if there is any way to reduce the size of the example file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% I'll check into it this week. Just getting caught up with these arrow-test PRs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delayed reviews

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delayed reviews

@alamb It's all good. You're literally everywhere, I totally get it. In fact thank you for getting to them at the pace you are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants