Run boolean and bitwise kernels for longer to reduce noise #8872
+105
−41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to self:
Which issue does this PR close?
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax.
Rationale for this change
The boolean and bitwise kernels are currently very noisy and sometimes get nonsensical results (e.g. #8854 (comment)) I think this is because they are so fast. For example, Here is an output from a recent run (note the benchmark each takes only nanoseconds
What changes are included in this PR?
Are these changes tested?
I will benchmark then
Are there any user-facing changes?
No these are benchmarks