Make ArrowReaderOptions::with_virtual_columns error rather than panic on invalid input
#8867
+37
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic on invalid input
alamb
commented
Nov 18, 2025
| /// # } | ||
| /// ``` | ||
| pub fn with_virtual_columns(self, virtual_columns: Vec<FieldRef>) -> Self { | ||
| pub fn with_virtual_columns(self, virtual_columns: Vec<FieldRef>) -> Result<Self> { |
Contributor
Author
There was a problem hiding this comment.
The point of the PR is to change this API to avoid panic'ing
Contributor
Author
10 tasks
etseidl
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
RowNumberReaderwhen not all row groups are selected #8863Rationale for this change
per #8715 (comment), @scovich rightly says
It is much better for a user facing API to return an error on invalid input than painc
What changes are included in this PR?
ArrowReaderOptions::with_virtual_columnserror rather than panic on invalid inputAre these changes tested?
Yes by CI
Are there any user-facing changes?
While this is an API change it was introduced in #8715 which has not yet been released. Therefore, we can make this change without breaking semver.