Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Nov 16, 2025

Which issue does this PR close?

We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax.

Rationale for this change

While reviewing #8849 from @Dandandan

I realized we don't have good examples for going from MutableBuffer to Vec, so it may not be clear to users how to use it.

So let's add some examples in the docs for MutableBuffer

What changes are included in this PR?

Add examples / update docs

Are these changes tested?

By CI

Are there any user-facing changes?

New docs, no functional changes

@alamb alamb added the documentation Improvements or additions to documentation label Nov 16, 2025
@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 16, 2025
Copy link
Contributor

@etseidl etseidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks as always @alamb. Definitely an improvement.

@alamb
Copy link
Contributor Author

alamb commented Nov 17, 2025

Thanks for the review @etseidl

alamb added a commit that referenced this pull request Nov 18, 2025
# Which issue does this PR close?

- Similar to #8852

# Rationale for this change

It my not be clear how to convert to a MutableBuffer, so let's add some
doc examples

# What changes are included in this PR?

Add doc examples
# Are these changes tested?

Yes by CI

# Are there any user-facing changes?
More docs, no functional change
@alamb alamb merged commit c5c8076 into apache:main Nov 18, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants