[Parquet] Avoid fetching multiple pages when the predicate cache is disabled #8554
+97
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Oct 6, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @nuno-faria -- this looks very great to me
| .unwrap(); | ||
| let parquet_schema = metadata.file_metadata().schema_descr_ptr(); | ||
|
|
||
| // the filter is not clone-able, so we use a lambda to simplify |
Contributor
There was a problem hiding this comment.
yeah, this is something that makes the filters very tricky to handle internally. Nothing to change for this PR, I am just observing
Contributor
|
FYI @XiangpengHao |
XiangpengHao
approved these changes
Oct 6, 2025
Contributor
XiangpengHao
left a comment
XiangpengHao
left a comment
There was a problem hiding this comment.
Looks good to me, thank you @nuno-faria
Contributor
|
Thanks again @nuno-faria and @XiangpengHao |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
max_predicate_cache_sizeis 0 #8542.Rationale for this change
When the
max_predicate_cache_sizeis set to 0 there is no need to select multiple data pages untilbatch_sizeis reached.What changes are included in this PR?
ReaderFactory::compute_cache_projectionreturnNoneif the cache is disabled, which will end up not retrieving multiple pages unnecessarily.Are these changes tested?
Yes.
Are there any user-facing changes?
No.