-
Notifications
You must be signed in to change notification settings - Fork 1k
[Geospatial]: Scaffolding for new parquet-geospatial
crate
#8375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Geospatial]: Scaffolding for new parquet-geospatial
crate
#8375
Conversation
parquet-geometry
crate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Feel free to lift SedonaDB's Interval and BoundingBox implementation, which is the only one I know about that implements the "wraparound" version of the bounding box we adopted in the spec.
https://github.com/apache/sedona-db/blob/main/rust/sedona-geometry/src/interval.rs
https://github.com/apache/sedona-db/blob/main/rust/sedona-geometry/src/bounding_box.rs
...or if there's a more appropriate place to upstream those I can do that too. (I wrote that code and am happy to do the PR if that's cleaner IP wise).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me -- thank you @kylebarron . I double checked most of the links and they are 👌
A good follow on PR might be to add CI checks for this crate, similar to https://github.com/apache/arrow-rs/blob/main/.github/workflows/parquet-variant.yml
how about naming it |
Or |
We used a |
parquet-geometry
crateparquet-geospatial
crate
parquet-geospatial
crateparquet-geospatial
crate
Which issue does this PR close?
parquet-geometry
crate #8374.Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?