Skip to content

Conversation

kylebarron
Copy link
Contributor

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@kylebarron kylebarron changed the title Create scaffolding for new parquet-geometry crate [Geometry]: Scaffolding for new parquet-geometry crate Sep 17, 2025
Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Feel free to lift SedonaDB's Interval and BoundingBox implementation, which is the only one I know about that implements the "wraparound" version of the bounding box we adopted in the spec.

https://github.com/apache/sedona-db/blob/main/rust/sedona-geometry/src/interval.rs

https://github.com/apache/sedona-db/blob/main/rust/sedona-geometry/src/bounding_box.rs

...or if there's a more appropriate place to upstream those I can do that too. (I wrote that code and am happy to do the PR if that's cleaner IP wise).

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me -- thank you @kylebarron . I double checked most of the links and they are 👌

A good follow on PR might be to add CI checks for this crate, similar to https://github.com/apache/arrow-rs/blob/main/.github/workflows/parquet-variant.yml

@petern48
Copy link
Contributor

how about naming it parquet-geo to be more inclusive of the geography datatype? i feel like naming it parquet-geometry might mislead others into thinking geography is a special case of geometry rather than them being two distinct types.

@kylebarron
Copy link
Contributor Author

Or parquet-geospatial to be more descriptive while avoiding the name geometry

@paleolimbot
Copy link
Member

We used a geospatial/ subdirectory in C++ 🤷 (I don't really mind, I think folks will get the jist of it 🙂 )

@alamb alamb changed the title [Geometry]: Scaffolding for new parquet-geometry crate [Geometry]: Scaffolding for new parquet-geospatial crate Sep 17, 2025
@kylebarron kylebarron changed the title [Geometry]: Scaffolding for new parquet-geospatial crate [Geospatial]: Scaffolding for new parquet-geospatial crate Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Geospatial] Create new parquet-geometry crate
5 participants