-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Closed
Labels
Description
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
This issue wants to make improvements for the list builder like #7899 for Object Builder
Describe the solution you'd like
What I would like to do is avoid the extra allocation to improve performance
Describe alternatives you've considered
- Change the ListBuilder so it remembers where the list should start in the parent's buffer
- Remove
ListBuilder::buffer - On append, the ListBuilder writes directly into the parent's buffer
- On
ListBuilder::finishcompute how much space is needed for the offset, and shift the child list bytes down by that amount in the parent's buffer - Fill in the list header + offsets for the child array
- return
Additional context
alamb