Skip to content

Improve Unit Test Coverage of ArrayReaderBuilder #1484

@tustvold

Description

@tustvold

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Whilst working on #1483 I noticed that ArrayReaderBuilder has a single rather limited unit test. Whilst I think many codepaths are covered by tests at higher levels, it would be good to have some unit test coverage of what is a relatively non-trivial piece of code which walks the potentially nested parquet schema.

It may also be a worthwhile exercise to split up the relatively large functions into smaller functions that can be tested independently, with the added bonus of improving readability.

Describe the solution you'd like

Some more unit tests of this functionality

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementAny new improvement worthy of a entry in the changelogparquetChanges to the parquet crate

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions