-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Closed
Labels
enhancementAny new improvement worthy of a entry in the changelogAny new improvement worthy of a entry in the changelogparquetChanges to the parquet crateChanges to the parquet crate
Description
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Whilst working on #1483 I noticed that ArrayReaderBuilder has a single rather limited unit test. Whilst I think many codepaths are covered by tests at higher levels, it would be good to have some unit test coverage of what is a relatively non-trivial piece of code which walks the potentially nested parquet schema.
It may also be a worthwhile exercise to split up the relatively large functions into smaller functions that can be tested independently, with the added bonus of improving readability.
Describe the solution you'd like
Some more unit tests of this functionality
Metadata
Metadata
Assignees
Labels
enhancementAny new improvement worthy of a entry in the changelogAny new improvement worthy of a entry in the changelogparquetChanges to the parquet crateChanges to the parquet crate