-
Notifications
You must be signed in to change notification settings - Fork 94
GH-898: Upgrade to Apache POM 35 and identify fixes needed to have CI happy #865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
For the JNI Ubuntu, I see this message from archery: Checking for an update. |
|
https://github.com/apache/arrow-java/blob/main/compose.yaml#L102 I think we need to update our |
|
Yup agree. It's what I gonna try. |
4a95684 to
4051fbb
Compare
|
The error with cffi not being available for free-threaded means it's trying to use free-threaded wheels (an python) which is unexpected from what I understand: |
This comment has been minimized.
This comment has been minimized.
|
We need apache/arrow#47749 and diff --git a/ci/scripts/jni_macos_build.sh b/ci/scripts/jni_macos_build.sh
index f7543b6f..7f927d19 100755
--- a/ci/scripts/jni_macos_build.sh
+++ b/ci/scripts/jni_macos_build.sh
@@ -142,6 +142,7 @@ github_actions_group_begin "Checking shared dependencies for libraries"
pushd "${dist_dir}"
archery linking check-dependencies \
--allow CoreFoundation \
+ --allow Network \
--allow Security \
--allow libSystem \
--allow libarrow_cdata_jni \for macOS. |
|
We need apache/arrow#47746 and diff --git a/.env b/.env
index d3e1c1d6..a7783537 100644
--- a/.env
+++ b/.env
@@ -40,7 +40,7 @@ ARCH_SHORT=amd64
# Default repository to pull and push images from
REPO=ghcr.io/apache/arrow-java-dev
-ARROW_REPO=apache/arrow-dev
+ARROW_REPO=ghcr.io/apache/arrow-dev
# The setup attempts to generate coredumps by default, in order to disable the
# coredump generation set it to 0
@@ -53,5 +53,4 @@ MAVEN=3.9.9
# Versions for various dependencies used to build artifacts
# Keep in sync with apache/arrow
ARROW_REPO_ROOT=./arrow
-PYTHON=3.9
-VCPKG="f7423ee180c4b7f40d43402c2feb3859161ef625" # 2024.06.15 Release
+VCPKG="4334d8b4c8916018600212ab4dd4bbdc343065d1" # 2025.09.17 Release
diff --git a/ci/docker/vcpkg-jni.dockerfile b/ci/docker/vcpkg-jni.dockerfile
index 55fa35e0..d6bd322a 100644
--- a/ci/docker/vcpkg-jni.dockerfile
+++ b/ci/docker/vcpkg-jni.dockerfile
@@ -18,24 +18,10 @@
ARG base
FROM ${base}
-# Install the libraries required by Gandiva to run
-# Use enable llvm[enable-rtti] in the vcpkg.json to avoid link problems in Gandiva
-RUN vcpkg install \
- --clean-after-build \
- --x-install-root=${VCPKG_ROOT}/installed \
- --x-manifest-root=/arrow/ci/vcpkg \
- --x-feature=dev \
- --x-feature=flight \
- --x-feature=gcs \
- --x-feature=json \
- --x-feature=parquet \
- --x-feature=gandiva \
- --x-feature=s3
-
# Install Java
# We need Java for JNI headers, but we don't invoke Maven in this build.
ARG java=11
-RUN yum install -y java-$java-openjdk-devel && yum clean all
+RUN dnf install -y java-$java-openjdk-devel && dnf clean all
# For ci/scripts/{cpp,java}_*.sh
ENV ARROW_HOME=/tmp/local \
diff --git a/compose.yaml b/compose.yaml
index b125c3c9..f5082a22 100644
--- a/compose.yaml
+++ b/compose.yaml
@@ -99,7 +99,7 @@ services:
cache_from:
- ${REPO}:${ARCH}-vcpkg-jni-${VCPKG}
args:
- base: ${ARROW_REPO}:${ARCH}-python-${PYTHON}-wheel-manylinux-2014-vcpkg-${VCPKG}
+ base: ${ARROW_REPO}:${ARCH}-cpp-jni-${VCPKG}
volumes:
- .:/arrow-java:delegated
- ${ARROW_REPO_ROOT}:/arrow:delegatedfor Linux. |
|
I'm fixing the base image here (need to adapt). |
|
apache/arrow#47749 was merged and JNI jobs on macOS passed. |
|
@kou macos works now thanks. But not Ubuntu yet. I'm investigating. |
It's not merged yet. It's a blocker for Linux. |
and identify fixes needed to have CI happy
Co-authored-by: Sutou Kouhei <[email protected]>
06b9e8d to
0b47984
Compare
|
apache/arrow#47915 can fix the symbol error but it seems that Java process is crashed: BTW, can we reduce log from Maven? We can't use GitHub Actions UI to see logs because there are too many logs. (We need to use raw log instead...) |
|
Hmm, we've been running into this for a while now but haven't managed to actually track it down. |
|
We could disable the test. (Or just disable all tests...the JNI bindings are not very well tested in the first place.) |
…47915) ### Rationale for this change We need to use `orc_SOURCE` not `ORC_SOURCE` for Apache ORC and `glog_SOURCE` not `GLOG_SOURCE` for Google logging. ### What changes are included in this PR? Fix referred variable names. ### Are these changes tested? Yes in apache/arrow-java#865 . ### Are there any user-facing changes? Yes. * GitHub Issue: #47914 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
|
I can replicate the crash locally. I also see this: Not sure what's happening here. Linking issue? |
|
I can see the same in CI. I thought compute functions were automatically registered? Or did something about that change over time |
|
I don't think I have the time to investigate this. I'm at least willing to disable the tests and declare that dataset needs maintainers in order to continue... |
|
Ah, we need to call |
|
Ok, let me try that, thanks :) |
|
IMO, let's merge this PR as-is though? We can start unblocking other PRs and this has been around for a while |
|
OK. @jbonofre Could you create a new issue for this and update the PR title/description for the latest changes? |
|
@jbonofre do you mind if I just file the issue and close this out? |
|
@lidavidm maybe we can start by merging this one and create another issue/PR as follow up ? |
…tion (apache#47915) ### Rationale for this change We need to use `orc_SOURCE` not `ORC_SOURCE` for Apache ORC and `glog_SOURCE` not `GLOG_SOURCE` for Google logging. ### What changes are included in this PR? Fix referred variable names. ### Are these changes tested? Yes in apache/arrow-java#865 . ### Are there any user-facing changes? Yes. * GitHub Issue: apache#47914 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
Closes #898.