Skip to content

Conversation

@wgtmac
Copy link
Member

@wgtmac wgtmac commented May 9, 2025

No description provided.

@github-actions

This comment has been minimized.

@wgtmac wgtmac added the chore PRs that make misc changes. label May 9, 2025
@wgtmac wgtmac added this to the 18.3.0 milestone May 9, 2025
@wgtmac wgtmac requested a review from kou May 9, 2025 07:44
@wgtmac wgtmac mentioned this pull request May 9, 2025
5 tasks
@jbonofre
Copy link
Member

jbonofre commented May 9, 2025

That's not correct. It should be SNAPSHOT version as the release is done by the maven-release-plugin.

Copy link
Member

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use 18.3.0-SNAPSHOT

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

This is correct.

We don't create a release branch. We release a RC from main. So we should use no -SNAPSHOT version here.

@kou
Copy link
Member

kou commented May 9, 2025

FYI: We don't use maven-release-plugin for our release.

@kou
Copy link
Member

kou commented May 9, 2025

FYI: We don't use maven-release-plugin for our release.

Ah, sorry. We use maven-release-plugin. https://github.com/apache/arrow-java/blob/main/dev/release/bump_version.sh that creates this PR uses maven-release-plugin.

@jbonofre
Copy link
Member

jbonofre commented May 9, 2025

Yea AFAIR we use the maven plugin in the release script.

@kou
Copy link
Member

kou commented May 9, 2025

Do you still think we need -SNAPSHOT version in this PR?
(I think that we don't need -SNAPSHOT version. Our next release script https://github.com/apache/arrow-java/blob/main/dev/release/release_rc.sh just tags the commit that merges this PR.)

@wgtmac
Copy link
Member Author

wgtmac commented May 9, 2025

I think it is fine. The caveat is that the main branch must be kept unchanged until the release is done.

@kou
Copy link
Member

kou commented May 9, 2025

The caveat is that the main branch must be kept unchanged until the release is done.

Right. It's a restriction of the current release process.

@wgtmac
Copy link
Member Author

wgtmac commented May 9, 2025

Are you good with this PR? @jbonofre

Copy link
Member

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok as soon as the version is bumped to SNAPSHOT after the release

@wgtmac
Copy link
Member Author

wgtmac commented May 9, 2025

Thanks! Let me merge it and proceed.

@wgtmac wgtmac merged commit 8e84e4c into apache:main May 9, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore PRs that make misc changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants