-
Notifications
You must be signed in to change notification settings - Fork 94
MINOR: Bump version to 18.3.0 #741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
|
That's not correct. It should be SNAPSHOT version as the release is done by the maven-release-plugin. |
jbonofre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use 18.3.0-SNAPSHOT
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
This is correct.
We don't create a release branch. We release a RC from main. So we should use no -SNAPSHOT version here.
|
FYI: We don't use maven-release-plugin for our release. |
Ah, sorry. We use maven-release-plugin. https://github.com/apache/arrow-java/blob/main/dev/release/bump_version.sh that creates this PR uses maven-release-plugin. |
|
Yea AFAIR we use the maven plugin in the release script. |
|
Do you still think we need |
|
I think it is fine. The caveat is that the main branch must be kept unchanged until the release is done. |
Right. It's a restriction of the current release process. |
|
Are you good with this PR? @jbonofre |
jbonofre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok as soon as the version is bumped to SNAPSHOT after the release
|
Thanks! Let me merge it and proceed. |
No description provided.