Skip to content

Conversation

rgala
Copy link

@rgala rgala commented Jun 27, 2025

Force using libuuid on IBM i (OS400). LIBC procedures do not work on this platform (IBM/ibmi-oss-issues#82)

@rgala rgala force-pushed the uuid_usability_test_fix branch 12 times, most recently from 4dd33da to eee1ad8 Compare August 9, 2025 19:24
@rgala
Copy link
Author

rgala commented Aug 9, 2025

I have forced ac_cv_func_uuid_generate and ac_cv_search_uuid_generate to yes, but will have to test it. I remember I had problems with AC_CHECK_HEADERS finding uuid.h, which is for uuid functions in libc which have not been implemented by IBM, though the uuid.h file exists on the system anyway. This is why I made a logic to force use of uuid.h file from libuuid for IBM i.

This is the part of usability test that was the issue:

#if defined(HAVE_UUID_H)
#include <uuid.h>

Can HAVE_UUID_H be forced through hints too, with AC_DEFINE(HAVE_UUID_H, 0) maybe?

@notroj
Copy link
Contributor

notroj commented Aug 11, 2025

I have forced ac_cv_func_uuid_generate and ac_cv_search_uuid_generate to yes, but will have to test it. I remember I had problems with AC_CHECK_HEADERS finding uuid.h, which is for uuid functions in libc which have not been implemented by IBM, though the uuid.h file exists on the system anyway. This is why I made a logic to force use of uuid.h file from libuuid for IBM i.

This is the part of usability test that was the issue:

#if defined(HAVE_UUID_H)
#include <uuid.h>

Can HAVE_UUID_H be forced through hints too, with AC_DEFINE(HAVE_UUID_H, 0) maybe?

Use:

ac_cv_header_uuid_h=no
ac_cv_header_uuid_uuid_h=no

etc in the hints.

@rgala rgala force-pushed the uuid_usability_test_fix branch from a3a8e70 to 6edf146 Compare August 18, 2025 08:59
… not work on this platform (IBM/ibmi-oss-issues#82)

2. Added additional compilation parameters for building on IBM i
@rgala rgala force-pushed the uuid_usability_test_fix branch from 6edf146 to 2b7d79f Compare August 18, 2025 11:42
@brainy
Copy link
Member

brainy commented Aug 18, 2025

Looks OK now wrt conditionals, since there are no new ones any more.

Next time, please don't squash commits before merging; it's impossible to see what changed during review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants