Skip to content
This repository was archived by the owner on Jan 9, 2020. It is now read-only.

Conversation

@mccheah
Copy link

@mccheah mccheah commented Jan 31, 2017

docker-minimal-bundle now only includes the core, kubernetes, and sql modules of the
Spark project. The Dockerfiles are still valid for the main distribution
which includes all of the modules.

A small bug was found and fixed on the way in using jars that are mounted on the
docker image.

Closes #66

docker-minimal-bundle now only includes the core and sql modules of the
Spark project. The Dockerfiles are still valid for the main distribution
which includes all of the modules.

A small bug was found on the way in using jars that are mounted on the
docker image.
@mccheah mccheah changed the title Reduce pre-integration-test runtime. Reduce pre-integration-test runtime Jan 31, 2017
@mccheah
Copy link
Author

mccheah commented Feb 1, 2017

Build failure seems transient.

@ash211
Copy link

ash211 commented Feb 1, 2017

@ssuchter this is the PR I mentioned that might make integration tests faster

@ssuchter
Copy link
Member

ssuchter commented Feb 1, 2017 via email

@mccheah
Copy link
Author

mccheah commented Feb 1, 2017

Note this isn't primarily for reducing docker image size - the removal of a few jars is negligible. This primarily focuses on removing compilation steps from the Maven flow, so running pre-integration-test to prepare the environment for running tests in an IDE is faster. I think we can get even faster if we remove the dependency on SQL and just use raw SparkContext operations.

@cvpatel
Copy link
Member

cvpatel commented Feb 1, 2017

Thanks @mccheah, this will also help in reducing the integration test run time :). Also, I had had to apply this patch locally to get the tests working.

I'll submit a PR with the travis changes I was trying out so we continue the discussion there on what to include.

@mccheah
Copy link
Author

mccheah commented Feb 1, 2017

I'm not sure if the overall build time will reduce by a significant amount since the full build over all modules needs to run anyways. We could conceivably decide to make our Travis CI only run the kubernetes/* and core modules though since those are the only things we will be changing.

@cvpatel
Copy link
Member

cvpatel commented Feb 2, 2017

Have created #74, PTAL. We can discuss further modifications to what we run with Travis there.

@mccheah
Copy link
Author

mccheah commented Feb 16, 2017

This is unfortunately out of date and probably would be easier to revisit from the ground up later on. I'm going to close this but I'll revisit this in post-alpha.

@mccheah mccheah closed this Feb 16, 2017
ifilonenko pushed a commit to ifilonenko/spark that referenced this pull request Feb 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants