This repository was archived by the owner on Jan 9, 2020. It is now read-only.
Fix duplicated secret volume in pod spec #595
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@hex108 apache#20148 has been merged. Can you refactor this PR? Thanks! |
Author
|
@liyinan926 Ah, might it be better to cherry-pick your patch at apache#20148? |
Member
|
Yep, that sounds good to me. |
Member
|
I'm gonna cherry-pick the changes in apache#20148 and create a new PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix #594
How was this patch tested?
Unit test and manual test.