This repository was archived by the owner on Jan 9, 2020. It is now read-only.
Use the new initContainers field instead of the deprecated annotation #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Any other interesting changes brought about by the fabric8 upgrade? |
Member
Author
|
@foxish will do some research on that. |
Member
Author
|
rerun integration tests please |
1 similar comment
Member
Author
|
rerun integration tests please |
felixcheung
reviewed
Oct 19, 2017
felixcheung
left a comment
felixcheung
left a comment
There was a problem hiding this comment.
does this change the required minimum version of k8s?
Member
Author
|
@felixcheung Yes, this change requires k8s 1.6 and up. |
|
Hmm.. as a side note, I couldn't find description on k8s version requirements, could we add to README.md? |
Member
Author
|
@felixcheung good point. I will add to https://github.com/apache-spark-on-k8s/userdocs/blob/master/src/jekyll/running-on-kubernetes.md once this PR is merged. |
Member
Author
|
rerun integration tests please |
Member
Author
|
Doc updates for minimum k8s version requirement in apache-spark-on-k8s/userdocs#18. |
Member
|
LGTM! Will merge EOD if no further comments. |
3 tasks
puneetloya
pushed a commit
to puneetloya/spark
that referenced
this pull request
Mar 11, 2019
…apache-spark-on-k8s#528) * Use the new initContainers field in Kubernetes 1.8 * Fixed the integration tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixes #524. Changes to use the new
initContainersfield instead of the deprecated annotation, support of which is dropped as of Kubernetes 1.8. This requires updating the version of the fabric8 kubernetes-client.