This repository was archived by the owner on Jan 9, 2020. It is now read-only.
Create README to better describe project purpose #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ash211
commented
Jan 26, 2017
| - Intel | ||
| - Palantir | ||
| - Pepperdata | ||
| - Red Hat |
Author
There was a problem hiding this comment.
if I've left anyone off, or anyone wants this list changed, please let me know either here or in private
mccheah
suggested changes
Jan 26, 2017
mccheah
left a comment
mccheah
left a comment
There was a problem hiding this comment.
Small wording thing but overall seems ok.
README.md
Outdated
|
|
||
| ## Why does this fork exist? | ||
|
|
||
| Adding native integration for a new cluster manager is a large undertaking. If poorly executed, it could introduce bugs into Spark when run on other cluster managers, cause release blockers slowing down the overall Spark project, or require hotfixes which divert attention away from development towards managing additional releases. Any work this core in Spark needs to be done carefully to minimize the risk of those negative externalities. |
There was a problem hiding this comment.
"Any work this core in Spark" - what does this mean?
Author
There was a problem hiding this comment.
Changed to "Any work this deep inside Spark"
foxish
reviewed
Jan 27, 2017
README.md
Outdated
|
|
||
| - [Usage guide](docs/running-on-kubernetes.md) shows how to run the code | ||
| - [Development docs](resource-managers/kubernetes/README.md) shows how to get set up for development | ||
| - Code is primarily located in the [resource-managers/kubernetes](resource-managers/kubernetes) module |
Member
There was a problem hiding this comment.
nit: We have multiple modules within that directory, but I think you don't mean module here in the maven sense.
README.md
Outdated
|
|
||
| Adding native integration for a new cluster manager is a large undertaking. If poorly executed, it could introduce bugs into Spark when run on other cluster managers, cause release blockers slowing down the overall Spark project, or require hotfixes which divert attention away from development towards managing additional releases. Any work this core in Spark needs to be done carefully to minimize the risk of those negative externalities. | ||
|
|
||
| At the same time, an increasing number of people from varying companies and organizations desire to work together to natively run Spark on Kubernetes. The group needs a code repository, communication forum, issue tracking, and continuous integration, all in order to work together effectively on an open source product. |
Author
Member
|
LGTM |
|
Looks great! I'm going to merge. |
mccheah
approved these changes
Jan 28, 2017
ash211
added a commit
that referenced
this pull request
Feb 8, 2017
* Create README to better describe project purpose * Add links to usage guide and dev docs * Minor changes
ash211
added a commit
that referenced
this pull request
Mar 8, 2017
* Create README to better describe project purpose * Add links to usage guide and dev docs * Minor changes
foxish
pushed a commit
that referenced
this pull request
Jul 24, 2017
* Create README to better describe project purpose * Add links to usage guide and dev docs * Minor changes
ifilonenko
pushed a commit
to ifilonenko/spark
that referenced
this pull request
Feb 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35