-
Notifications
You must be signed in to change notification settings - Fork 117
Rename package to k8s #497
Conversation
|
Let's merge this after the new 2.2 release. |
mccheah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - also good that the non-code references were corrected, such as the Dockerfiles.
|
On second thought, maybe we should include this in the release. It will help folks migrate to the upstream one without jumping through hoops. WDYT @mccheah @liyinan926 |
|
@foxish I think this should go into the new release. It's better doing it earlier than later. It makes the upcoming upstreaming PRs easier to go by. |
|
Agreed. It's low-risk since the failures would have been fairly obvious. |
|
@varunkatta @ssuchter The Jenkins environment needs to be updated since the commands had a wildcard on |
|
Good catch @ifilonenko! We should do this asap. Manually verifying that integration tests are okay. |
|
I just saw this thread. I’m not sure what updates I’d need to make. Also,
I’m mention - if anyone needs a jenkins UI login that doesn’t have it, just
let me know.
Sean
On September 24, 2017 at 5:44:40 PM, Anirudh Ramanathan ( [email protected]) wrote:
Good catch @ifilonenko <https://github.com/ifilonenko>! We should do this
asap. Manually verifying that integration tests are okay.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#497 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB2E24EjAxqc7OviQ3wORISvDkn3wEhJks5slvd4gaJpZM4PdNLM>
.
|
|
The integration tests run:
We need to change the last argument to |
|
I made the change already. I see that you both have usernames on the
jenkins already - I’ll contact you on slack about that.
Sean
On September 25, 2017 at 8:48:49 AM, Anirudh Ramanathan ( [email protected]) wrote:
The integration tests run:
./build/mvn -B -Dmaven.repo.local=/home/jenkins/.m2/pr_intg_test_repo clean
integration-test -Pkubernetes -Pkubernetes-integration-tests -pl
resource-managers/kubernetes/integration-tests -am -Dtest=none
-DwildcardSuites=org.apache.spark.deploy.kubernetes.integrationtest.KubernetesSuite
We need to change the last argument to
-DwildcardSuites=org.apache.spark.deploy.k8s.integrationtest.KubernetesSuite
.
Can you create a login/pass for me and Ilan? Then we could probably do this
directly.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#497 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB2E23sw_6R_ka9-z_h4n4EZ-gFMEo-Fks5sl8tcgaJpZM4PdNLM>
.
|
* Rename package to k8s * Rename string constants
* Rename package to k8s * Rename string constants
/xref #492 (comment)
cc @apache-spark-on-k8s/contributors