This repository was archived by the owner on Jan 9, 2020. It is now read-only.
Fix conversion from GB to MiB #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we applied a value which was in units MiB to Kubernetes _as if_ it were in MB units. Now, place MiB units in variable names and apply them to Kubernetes as the correct MiB units.
Member
|
LGTM. |
mccheah
approved these changes
Aug 29, 2017
Author
|
Will merge when builds pass |
puneetloya
pushed a commit
to puneetloya/spark
that referenced
this pull request
Mar 11, 2019
* Fix conversion from GB to MiB Previously we applied a value which was in units MiB to Kubernetes _as if_ it were in MB units. Now, place MiB units in variable names and apply them to Kubernetes as the correct MiB units. * Fix test * Update tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #467
Previously we applied a value which was in units MiB to Kubernetes as if it were in MB units. Now, place MiB units in variable names and apply them to Kubernetes as the correct MiB units.