Skip to content
This repository was archived by the owner on Jan 9, 2020. It is now read-only.

Conversation

@liyinan926
Copy link
Member

Added the missing install step for those who compile the Kubernetes core implementation module for the first time.

@erikerlandson
Copy link
Member

This seems inconsistent with maven docs, which claim that install implies the compile goal. Why does install need to be run first?

(install) executes each default life cycle phase in order (validate, compile, package, etc.), before executing install. You only need to call the last build phase to be executed, in this case, install:

@liyinan926
Copy link
Member Author

It seems compile may complain about missing dependencies if this is the first time to try to compile.

@erikerlandson
Copy link
Member

it definitely does, although I've been confused about why for some time.

@foxish
Copy link
Member

foxish commented Aug 8, 2017

I usually run package in my general workflow, which should do the validate and compile as well.
We could just keep that. The install step is useful for speeding up subsequent builds.

I don't think we need to suggest the mvn compile separately at all.

@mccheah
Copy link

mccheah commented Aug 15, 2017

If the -am flag is provided to the build reactor, the dependencies should be built and also available for use in the downstream projects. However this behavior has been inconsistent for me as of late and I haven't explored as to why.

@ash211
Copy link

ash211 commented Aug 21, 2017

This is now the second time someone has suggested adding this to the docs (earlier was #382) so clearly people would find it helpful.

I'm going to merge this PR since it's more current and comprehensive than the other one, and we can figure out the resolution issues separately

@ash211 ash211 merged commit 58cebd1 into apache-spark-on-k8s:branch-2.2-kubernetes Aug 21, 2017
ifilonenko pushed a commit to ifilonenko/spark that referenced this pull request Feb 26, 2019
…er-plugin-publish-fix

Ensure bintray upload happens before repository is no clean.
puneetloya pushed a commit to puneetloya/spark that referenced this pull request Mar 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants