This repository was archived by the owner on Jan 9, 2020. It is now read-only.
Retry binding server to random port in the resource staging server test. #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccheah
commented
Jul 18, 2017
| for (i <- 1 to MAX_SERVER_START_ATTEMPTS) { | ||
| serverPort = new ServerSocket(0).getLocalPort | ||
| try { | ||
| server = new ResourceStagingServer(serverPort, serviceImpl, sslOptionsProvider) |
Author
There was a problem hiding this comment.
We need to break out of the loop if this succeeds
|
Saw this exception when running tests: |
|
@mccheah unit tests failed with: |
Author
|
We have to start the server in the try block before concluding that the port is good to use. |
ash211
approved these changes
Jul 19, 2017
|
|
||
| if (Utils.isBindCollision(e)) { | ||
| currentAttempt += 1 | ||
| latestServerPort = latestServerPort + 1 |
There was a problem hiding this comment.
could do a randomization strategy more effective than +=1 but should already significantly reduce chances of collision
foxish
pushed a commit
that referenced
this pull request
Jul 24, 2017
…st. (#378) * Retry binding server to random port in the resource staging server test. * Break if successful start * Start server in try block. * FIx scalastyle * More rigorous cleanup logic. Increment port numbers. * Move around more exception logic. * More exception refactoring. * Remove whitespace * Fix test * Rename variable
puneetloya
pushed a commit
to puneetloya/spark
that referenced
this pull request
Mar 11, 2019
…st. (apache-spark-on-k8s#378) * Retry binding server to random port in the resource staging server test. * Break if successful start * Start server in try block. * FIx scalastyle * More rigorous cleanup logic. Increment port numbers. * Move around more exception logic. * More exception refactoring. * Remove whitespace * Fix test * Rename variable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.