Skip to content
This repository was archived by the owner on Jan 9, 2020. It is now read-only.

Conversation

@mccheah
Copy link

@mccheah mccheah commented Jun 13, 2017

  • Remove extraneous Feign dependency that we no longer use in submission v2.
  • Exclude Jackson from various modules to ensure every Jackson module is forced to 2.6.5 (the version Spark uses).
  • Fix a linter error only caught by sbt.
  • Add Kubernetes module to sparktestsupport and other SBT infrastructure

@mccheah
Copy link
Author

mccheah commented Jun 13, 2017

I didn't include the Kubernetes integration tests in the SBT build just yet - I'm not sure how we would translate the Maven steps into the appropriate SBT ones. It's probably fine to leave that for a future patch.

@ash211
Copy link

ash211 commented Jun 13, 2017

The difference between this PR and #274 previously is that the ./dev/run-tests via SBT doesn't run the new k8s tests without the change here to dev/sparktestsupport/modules.py

mccheah added 2 commits June 13, 2017 14:25
- Remove extraneous Feign dependency that we no longer use in submission
v2.
- Exclude Jackson from various modules to ensure every Jackson module is
forced to 2.6.5.
- Fix a linter error only caught by sbt.
- Add Kubernetes modules to various parts of the SBT infrastructure
@mccheah mccheah force-pushed the sbt-build-patches branch from 65a9823 to dcc8ef5 Compare June 13, 2017 21:25
@mccheah mccheah mentioned this pull request Jun 13, 2017
Copy link

@ash211 ash211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Planning to merge when build passes -- otherwise running tests with ./dev/run-tests doesn't include k8s tests, which are currently broken due to the unintentional jackson version change

@ash211 ash211 merged commit d6a3111 into branch-2.1-kubernetes Jun 14, 2017
@ash211 ash211 deleted the sbt-build-patches branch June 14, 2017 04:52
foxish pushed a commit that referenced this pull request Jul 24, 2017
* Fix sbt build.

- Remove extraneous Feign dependency that we no longer use in submission
v2.
- Exclude Jackson from various modules to ensure every Jackson module is
forced to 2.6.5.
- Fix a linter error only caught by sbt.
- Add Kubernetes modules to various parts of the SBT infrastructure

* Actually remove feign

* Actually exclude Jackson from kubernetes client.
ifilonenko pushed a commit to ifilonenko/spark that referenced this pull request Feb 26, 2019
…titeratorwithorigin

transformexpression with origin
puneetloya pushed a commit to puneetloya/spark that referenced this pull request Mar 11, 2019
* Fix sbt build.

- Remove extraneous Feign dependency that we no longer use in submission
v2.
- Exclude Jackson from various modules to ensure every Jackson module is
forced to 2.6.5.
- Fix a linter error only caught by sbt.
- Add Kubernetes modules to various parts of the SBT infrastructure

* Actually remove feign

* Actually exclude Jackson from kubernetes client.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants