Skip to content
This repository was archived by the owner on Jan 9, 2020. It is now read-only.

Conversation

@foxish
Copy link
Member

@foxish foxish commented Jan 18, 2017

Addressing part of #17
This should ensure we create unique driver/service names in every invocation.

@mccheah
Copy link

mccheah commented Jan 19, 2017

This would make it difficult for the user to look up the pod by name. Could it not be a requirement that spark.app.name needs to be a unique Kubernetes application? Or perhaps we don't anticipate users looking up the spawned pod that often, in which case this is fine.

@iyanuobidele
Copy link

iyanuobidele commented Jan 19, 2017

I'm guessing @foxish is thinking ahead about exposing the status of the spark job using the TPR, removing the need for direct contact with the pods created for a specific spark job.

Or perhaps we don't anticipate users looking up the spawned pod that often, in which case this is fine.

Either way, this is correct.

@ash211
Copy link

ash211 commented Jan 19, 2017

If someone wants to look up a driver pod via an identifier they could use labels instead after #27 merges. We probably shouldn't be trying to bake extra meaning into names anyway.

As a related suggestion, does it make sense to apply spark.app.name and spark.app.id as labels to the created pods for that lookup purpose? Is this a pattern seen elsewhere in k8s?

@foxish
Copy link
Member Author

foxish commented Jan 19, 2017

This pattern fits in with the other controllers, such as Job.

As a related suggestion, does it make sense to apply spark.app.name and spark.app.id as labels to the created pods for that lookup purpose? Is this a pattern seen elsewhere in k8s?

Yes, the "name = foo" pattern is used quite a bit, and it would help find these pods like you said. kubectl takes the --selector commandline option to allow filtering by label in case one is using the CLI.

@ash211
Copy link

ash211 commented Jan 19, 2017

I'll file a separate ticket for that and look into adding it. Let's merge this one so we get unique names now.

@ash211 ash211 merged commit 93f4cdc into k8s-support-alternate-incremental Jan 19, 2017
@ash211 ash211 deleted the unique-pod-name branch January 19, 2017 01:34
ifilonenko pushed a commit to ifilonenko/spark that referenced this pull request Feb 25, 2019
ifilonenko pushed a commit to ifilonenko/spark that referenced this pull request Feb 25, 2019
puneetloya pushed a commit to puneetloya/spark that referenced this pull request Mar 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants