Skip to content
This repository was archived by the owner on Jan 9, 2020. It is now read-only.

Conversation

@lins05
Copy link

@lins05 lins05 commented Apr 23, 2017

I want to build the project with sbt mainly because i want to set it up with ensime.

However, the build with sbt (./build/sbt -Pkubernetes -Phadoop-2.6 -Pkubernetes-integration-tests -Pmesos -Pyarn -Phive compile test:compile) failed with scalastyle check errors:

$ ./dev/scalastyle
Scalastyle checks failed at following occurrences:
[error] /data/github/spark/spark-k8s/resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/rest/kubernetes/v2/ResourceStagingServerSslOptionsProviderSui
te.scala:99: File line length exceeds 100 characters
[error] /data/github/spark/spark-k8s/resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/kubernetes/SSLUtils.scala:23:0: import.ordering.wrongOrderInG
roup.message
[error] (kubernetes/test:scalastyle) errors exist
[error] Total time: 10 s, completed Apr 23, 2017 3:34:14 PM

Copy link

@mccheah mccheah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@lins05 lins05 force-pushed the k8s-fix-scalastyle branch from 6e9c6ad to 1f368a7 Compare April 29, 2017 02:57
@lins05
Copy link
Author

lins05 commented Apr 29, 2017

@mccheah Can we merge this one?

@foxish
Copy link
Member

foxish commented May 3, 2017

This LGTM. Merging after tests pass. Thanks @lins05

@foxish foxish merged commit ba151c0 into apache-spark-on-k8s:branch-2.1-kubernetes May 3, 2017
@lins05 lins05 deleted the k8s-fix-scalastyle branch May 4, 2017 01:28
ifilonenko pushed a commit to ifilonenko/spark that referenced this pull request Feb 26, 2019
Would use 2.6.7 everywhere but upstream released a 2.6.7.1 for
jackson-databind but not a corresponding 2.6.7 for the rest of jackson, so
those remain on 2.6.7

This requires splitting the version variable in /pom.xml
puneetloya pushed a commit to puneetloya/spark that referenced this pull request Mar 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants