This repository was archived by the owner on Jan 9, 2020. It is now read-only.
Allow custom annotations on the driver pod #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@ash211 @iyanuobidele for review |
ash211
approved these changes
Mar 1, 2017
ash211
left a comment
ash211
left a comment
There was a problem hiding this comment.
Seems good to me. Definitely can see use cases for annotations in addition to labels.
@iyanuobidele if you don't see any problems please feel free to merge after your review.
|
LGTM! This would be very useful down the road. Talking #157. Merging. |
ash211
pushed a commit
that referenced
this pull request
Mar 8, 2017
foxish
pushed a commit
that referenced
this pull request
Jul 24, 2017
ifilonenko
pushed a commit
to ifilonenko/spark
that referenced
this pull request
Feb 25, 2019
(cherry picked from commit 21fb9b7)
puneetloya
pushed a commit
to puneetloya/spark
that referenced
this pull request
Mar 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.