This repository was archived by the owner on Jan 9, 2020. It is now read-only.
Shutdown log watcher explicitly when launcher completes #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccheah
reviewed
Feb 24, 2017
| } finally { | ||
| kubernetesResourceCleaner.deleteAllRegisteredResourcesFromKubernetes(kubernetesClient) | ||
| if (loggingWatch.nonEmpty) { | ||
| loggingWatch.get.shutdown() |
There was a problem hiding this comment.
I would expect close to handle this and that we would catch this since we wrap the call in a `tryWithResource1 - is this not the case?
There was a problem hiding this comment.
Unfortunately right now a Watch's onClose callback doesn't get called -- see fabric8io/kubernetes-client#674
There was a problem hiding this comment.
Hm, I think we should prefer fixing what's upstream as opposed to adding to our code.
Member
Author
There was a problem hiding this comment.
@mccheah SGTM. Let me close this PR. We can always revisit when and if there are future issues.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Addresses potentially remaining problems of #143 by explicitly shutting down the log watcher when the launcher completes. The main problem of #143 is fixed by #154, but the symptom may reappear if we fail to detect DELETED events due to upstream k8s client bugs. I think this patch will help in such a case.
cc @ash211 @foxish
How was this patch tested?
Ran integration test. Ran manual tests against the case of #143 before #154 is merged in.