This repository was archived by the owner on Jan 9, 2020. It is now read-only.
Pull component readiness logic to another class #124
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te-incremental' into ingress-support
mccheah
changed the title
mccheah
force-pushed
the
refactor-component-readiness
branch
from
8ac8ede to
583bfe0
Compare
Author
|
Soft dependency on #123 to fix merge conflicts as we go along. |
|
At first look: I'll review them (the refactor PRs) more closely tomorrow. |
mccheah
force-pushed
the
refactor-ssl
branch
from
1659810 to
4ba1f46
Compare
mccheah
force-pushed
the
refactor-component-readiness
branch
from
583bfe0 to
fe97704
Compare
…te-incremental' into ingress-support
Create a KubernetesComponentsCleaner which can register arbitrary pods, services, secrets, and ingresses. When an exception is thrown or the JVM shuts down, the cleaner automatically purges any of its registered components from Kubernetes. The components can be unregistered when the driver successfully begins running, so that the application persists beyond the lifetime of the spark-submit process.
mccheah
force-pushed
the
refactor-ssl
branch
from
60ce1d9 to
292a862
Compare
mccheah
force-pushed
the
refactor-component-readiness
branch
from
00a5823 to
1ed7ad2
Compare
mccheah
force-pushed
the
refactor-ssl
branch
from
292a862 to
81463b8
Compare
|
Now that the SSL refactoring PR is in this one is ready for rebase and separation from the Ingress PR |
Author
|
This seems difficult to rebase though - I'm fine just re-building this from scratch, especially after the code churn from #147 . |
ifilonenko
pushed a commit
to ifilonenko/spark
that referenced
this pull request
Feb 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull out waiting for components to be ready to a separate class.
Part of #109