This repository was archived by the owner on Jan 9, 2020. It is now read-only.
Adding legacyHostIP to the list of IPs we look at #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks ok to fix Minikube, although it would be good to follow up on the Minikube side to see why it's returning the new IP type in the first place. @foxish any idea why that is the case now? |
mccheah
approved these changes
Feb 14, 2017
Member
Author
|
It is deprecated, so, Minikube should move away from it and set the External/Internal IP. I'm not sure why they're still setting that parameter instead. |
Member
|
We have an on-premiss kubernetes 1.4 cluster that also has LegacyHostIP/InternalIP. So this fix helps us. |
ash211
pushed a commit
that referenced
this pull request
Mar 8, 2017
foxish
added a commit
that referenced
this pull request
Jul 24, 2017
ifilonenko
pushed a commit
to ifilonenko/spark
that referenced
this pull request
Feb 25, 2019
ifilonenko
pushed a commit
to ifilonenko/spark
that referenced
this pull request
Feb 25, 2019
puneetloya
pushed a commit
to puneetloya/spark
that referenced
this pull request
Mar 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix minikube issue in #112