This repository was archived by the owner on Jan 9, 2020. It is now read-only.
Use alpine and java 8 for docker images. #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccheah
commented
Jan 11, 2017
| RUN apt-get update && \ | ||
| apt-get install -y less openjdk-7-jre-headless net-tools vim-tiny sudo openssh-server procps && \ | ||
| rm -rf /var/lib/apt/lists/* | ||
| RUN apk add --update vim |
Author
There was a problem hiding this comment.
Mostly for debugging. Not sure what else we should add here, if anything.
There was a problem hiding this comment.
There's no vi by default? If so I'd want to keep this slimmer by not including vim
Author
There was a problem hiding this comment.
Ah good call, vi is there by default.
ash211
suggested changes
Jan 11, 2017
| RUN apt-get update && \ | ||
| apt-get install -y less openjdk-7-jre-headless net-tools vim-tiny sudo openssh-server procps && \ | ||
| rm -rf /var/lib/apt/lists/* | ||
| RUN apk add --update vim |
There was a problem hiding this comment.
There's no vi by default? If so I'd want to keep this slimmer by not including vim
|
|
||
| # Upgrade package index | ||
| # install a few other useful packages plus Open Jdk 7 | ||
| # Remove unneeded /var/lib/apt/lists/* after install to reduce the |
There was a problem hiding this comment.
this comment no longer applicable since you removed that line
|
|
||
| # Upgrade package index | ||
| # install a few other useful packages plus Open Jdk 7 | ||
| # Remove unneeded /var/lib/apt/lists/* after install to reduce the |
There was a problem hiding this comment.
this comment no longer applicable since you removed that line
Author
|
@ash211 anything else here? |
|
Nope, LGTM! |
ash211
pushed a commit
that referenced
this pull request
Feb 8, 2017
* Use alpine and java 8 for docker images. * Remove installation of vim and redundant comment
ash211
pushed a commit
that referenced
this pull request
Mar 8, 2017
* Use alpine and java 8 for docker images. * Remove installation of vim and redundant comment
foxish
pushed a commit
that referenced
this pull request
Jul 24, 2017
* Use alpine and java 8 for docker images. * Remove installation of vim and redundant comment
puneetloya
pushed a commit
to puneetloya/spark
that referenced
this pull request
Mar 11, 2019
* Use alpine and java 8 for docker images. * Remove installation of vim and redundant comment
ifilonenko
referenced
this pull request
in bloomberg/apache-spark-on-k8s
Mar 13, 2019
* Use alpine and java 8 for docker images. * Remove installation of vim and redundant comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first images were built more closely to what Spark has already done in their Mesos integration tests, but Alpine has a smaller image size and thus is quicker to pull and build with. Also use Java 8 instead of Java 7 as the base.