Skip to content
This repository was archived by the owner on Jan 9, 2020. It is now read-only.
This repository was archived by the owner on Jan 9, 2020. It is now read-only.

[Developer Workflow] Making PRs easier to review #263

@foxish

Description

@foxish

As discussed in today's meeting.
One issue with reviewing PRs is the volume of changes that are typical (500+ lines of changes), in which major parts tend to be boilerplate or fabric8 client code.
In order to speed up reviews, mechanisms suggested were:

  1. Discuss the top-2 most complex PRs in the SIG itself, spending ~5 minutes on each, with the author running us through the important parts
  2. Have more descriptive PR descriptions [pointing to specific files/"business logic"] to help cut through the noise.
  3. Secondary meetings where interested folks discuss and talk about specific parties (for PRs that may need more collaboration)

Thoughts?
cc @apache-spark-on-k8s/contributors

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions