[SOL] Fix debug relocation in SBF #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes anza-xyz/rust#131 |
Lichtso
approved these changes
Jun 28, 2025
LucasSte
merged commit ecdfcf8
into
anza-xyz:solana-rustc/19.1-2024-12-03
8 checks passed
LucasSte
added a commit
to LucasSte/llvm-project
that referenced
this pull request
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#65 rectified a problem in the old BPF target whereby we were emitting the wrong relocation type for debug sections.
After abandoning the
EM_BPFmachine flag, these lines were not patched.Solution
Swap
BPFbySBF.The definitive fix to the wrong relocation emission is in SBPFv3. See
FeatureRelocAbs64here:llvm-project/llvm/lib/Target/SBF/SBFTargetFeatures.td
Line 72 in 29ed9ce