Feat/field data refactoring #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| bool provideVertices = 3; // Provide vectices. | ||
| bool provideFaces = 4; // Provide faces information i.e. vertices connectivity. | ||
| bool provideFacesCentroid = 5; // Provide faces centroid. | ||
| bool provideFacesNormal = 6; // Provide faces normal. |
There was a problem hiding this comment.
Suggested change
| bool provideFacesNormal = 6; // Provide faces normal. | |
| bool provideFaceNormals = 6; // Provide face normals. |
The pluralization of the variables is not quite right (same for the other one).
dnwillia-work
approved these changes
Apr 7, 2022
ajain-work
force-pushed
the
feat/field_data_refactoring
branch
from
a187fcc to
1976e73
Compare
ajain-work
force-pushed
the
feat/field_data_refactoring
branch
from
1976e73 to
3bd999d
Compare
seanpearsonuk
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.