Set save-project-at-exit? #f in parametric server #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkundu1
force-pushed
the
feat/parametric-exit
branch
from
bf24085 to
ae3d184
Compare
dnwillia-work
approved these changes
Apr 8, 2022
There was a problem hiding this comment.
@mkundu1 Looks fine. A suggestion for future PRs would be to put the refactoring into a separate commit (do it first say) then put the actual commit after that. This way we can more easily review the change that addresses the underlying issue. I had to scroll through and hunt for it in this one...
tejalprabhu01
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion from Mayur to avoid a redundant save operation at exit - as discussed with @tejalprabhu01