Skip to content

Conversation

@mkundu1
Copy link
Contributor

@mkundu1 mkundu1 commented Apr 5, 2022

No description provided.

@mkundu1 mkundu1 force-pushed the feat/datamodelgen branch from 9c74e37 to cd7e9f0 Compare April 5, 2022 09:34
@mkundu1 mkundu1 marked this pull request as draft April 5, 2022 09:35
@mkundu1 mkundu1 requested a review from seanpearsonuk April 5, 2022 09:39
@mkundu1 mkundu1 force-pushed the feat/datamodelgen branch from cd7e9f0 to 9e256cf Compare April 5, 2022 10:57
@mkundu1 mkundu1 requested a review from ajain-work April 5, 2022 14:25
@seanpearsonuk
Copy link
Collaborator

@mkundu1 I need to get in touch with Mahendar et al about TaskObject.Execute which has a declared return type of Logical. In meshing console (or in PyFluent):

>>> workflow.TaskObject['Import Geometry'].Execute()
"Task executed TaskObject1
"
'menu-processing?'
>>> res = workflow.TaskObject['Import Geometry'].Execute()
"Task executed TaskObject1
"
>>> res
'menu-processing?'
>>> res = workflow.TaskObject['Add Local Sizing'].Execute()
>>> res
'menu-processing?'

The underlying commands are returning logical. If we document that TaskObject.Execute() returns bool then that won't match with the user's experience.

@mkundu1 mkundu1 changed the title Generate explicit datamodel classes - first pass Generate explicit datamodel classes Apr 6, 2022
@mkundu1 mkundu1 force-pushed the feat/datamodelgen branch 4 times, most recently from 49dbfe2 to 9185afc Compare April 7, 2022 06:31
@mkundu1 mkundu1 requested a review from dnwillia-work April 7, 2022 06:32
@mkundu1 mkundu1 marked this pull request as ready for review April 7, 2022 06:33
@mkundu1 mkundu1 force-pushed the feat/datamodelgen branch 2 times, most recently from 1705553 to 89b1ad9 Compare April 7, 2022 07:05
@mkundu1

This comment was marked as resolved.

@mkundu1 mkundu1 force-pushed the feat/datamodelgen branch from 89b1ad9 to 962f2f7 Compare April 7, 2022 11:02
@mkundu1 mkundu1 force-pushed the feat/datamodelgen branch from 962f2f7 to 2b873b6 Compare April 7, 2022 13:21
@mkundu1 mkundu1 merged commit f55c4c9 into main Apr 8, 2022
@mkundu1 mkundu1 deleted the feat/datamodelgen branch April 8, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants