-
Notifications
You must be signed in to change notification settings - Fork 56
Blocking post display. #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69a0b39 to
06b5582
Compare
ajain-work
commented
Apr 4, 2022
ajain-work
commented
Apr 4, 2022
mkundu1
reviewed
Apr 4, 2022
06b5582 to
cf2a2c2
Compare
Hi @ajain-work I have pushed branch tiny_change, which contains a couple of changes that I commented on your previous PR. Please incorporate here if you are happy with the changes. |
7ca2da6 to
e738f27
Compare
mkundu1
reviewed
Apr 4, 2022
fc8f8f8 to
acd59ea
Compare
acd59ea to
c59a35b
Compare
dnwillia-work
approved these changes
Apr 6, 2022
mkundu1
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default display is non blocking. Added post configuration, so that user can display in blocking mode.
Updated abstract interface with save_graphics API, to save hardcopy.
Resolves #257