Post unit tests. #232
Merged
Post unit tests. #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajain-work
force-pushed
the
feat/post_unit_test
branch
4 times, most recently
from
91d8d9b to
4beba8c
Compare
| MockLocalObjectDataExtractor, | ||
| ) | ||
|
|
||
|
|
There was a problem hiding this comment.
In future work (23 R1) perhaps we can think about abstracting the graphics window manager code? Either directly or by substituting its pyvista dependency.
ajain-work
force-pushed
the
feat/post_unit_test
branch
2 times, most recently
from
6d83b62 to
afc273a
Compare
seanpearsonuk
approved these changes
Mar 29, 2022
There was a problem hiding this comment.
Nice work, thanks, @ajain-work. 23 R1 we can look at abstracting the graphics dependency.
ajain-work
force-pushed
the
feat/post_unit_test
branch
from
afc273a to
5ba46b6
Compare
mkundu1
approved these changes
Mar 29, 2022
| def __init__(self, session): | ||
| """Instantiate XYPlots, containter of XYPlot.""" | ||
| session_state = XYPlots._sessions_state.get(session.id) | ||
| """Instantiate Plots, containter of plot objects.""" |
There was a problem hiding this comment.
Suggested change
| """Instantiate Plots, containter of plot objects.""" | |
| """Instantiate Plots, container of plot objects.""" |
ajain-work
force-pushed
the
feat/post_unit_test
branch
from
5ba46b6 to
2f8eb82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post graphics objects unit tests.