Skip to content

Conversation

@ypatel-qa
Copy link
Contributor

…heat transfer in a mixing elbow

@ypatel-qa ypatel-qa force-pushed the testing/mixing-elbow branch from fc52e42 to f704699 Compare March 22, 2022 13:54
else:
s.workflow.TaskObject["Import Geometry"].Arguments = dict(
FileName="mixing_elbow.pmdb", LengthUnit="in"
)
Copy link
Collaborator

@seanpearsonuk seanpearsonuk Mar 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another option is to create a string variable and assign it different values depending on the platform (or even just the extension part). Can also insert that conditional inline inside the dict instantiation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seanpearsonuk Thank you. I will make the change,

if os.name == "nt":
Part_Name = "mixing_elbow.scdoc"
else:
Part_Name = "mixing_elbow.pmdb"

s.workflow.TaskObject["Import Geometry"].Arguments = dict(
FileName=Part_Name, LengthUnit="in"
)

@akaszynski
Copy link
Contributor

akaszynski commented Mar 23, 2022

The binary/large files uploaded in this example and contained within this directory will not be easily downloaded when users attempt to download the example as in the mapdl examples:

image


The solution for these "extra" files is to use a "downloads" module within this library. See: https://github.com/pyansys/pymapdl/blob/main/src/ansys/mapdl/core/examples/downloads.py

This approach is used by DPF and PyAEDT as well. You can store your "example-data" in the https://github.com/pyansys/example-data repository. I'd recommend creating a pyfluent directory and following the same approach as pyaedt did with nesting subdirectories.

When implemented, this downloads/examples module will look like

from ansys.fluent.core import examples

# note that this method just returns a file path
file_name = examples.download_some_file()

# ... load file

@dnwillia-work
Copy link
Collaborator

dnwillia-work commented Mar 23, 2022

The binary/large files uploaded in this example and contained within this directory will not be easily downloaded when users attempt to download the example as in the mapdl examples:

Hi Alex, yup, we are planning to do that but for this example we are just trying to get it running at all at the moment.

@mkundu1
Copy link
Contributor

mkundu1 commented Mar 30, 2022

@ypatel-qa The example scripts have been merged with PR #222. You may close this PR.

@ypatel-qa ypatel-qa closed this Mar 30, 2022
@ypatel-qa ypatel-qa deleted the testing/mixing-elbow branch April 6, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants