-
Notifications
You must be signed in to change notification settings - Fork 56
Description
🐞 Problem
When reviewing your CI jobs, I realized that you are computing the coverage of your library, but you are indeed not uploading it. This is easily seen in the pyfluent/Makefile file, in section "unittest"
As you may see in the image, you are running a coverage analysis, but this analysis is just kept as a result of the log of the CI job. It could be beneficial to upload it and show the resulting coverage as part of the README buttons (in a similar fashion to GitHub Actions or License - please see pyansys/pymapdl)
💡 Proposed solution
The coverage results should be generated in XML and HTML formats so that they can be uploaded to a coverage visualization web page or tool. For example, in pyansys/pymapdl, they are using codecov.io which provides enhanced visualization graphs for code coverage review as well as other metrics. You can access the results in this link to get a grasp of the potential of this tool.
Another option would be uploading the HTML files as artifacts of the GitHub Actions process (CI). These artifacts would be uploaded in each run and they would be accessible for the end user - this way, one could download the HTML reports generated by pytest and process the line-by-line coverage easily
Proposed for evaluation and review: @dnwillia-work @seanpearsonuk @mkundu1
Once again, I'd be happy to implement the modifications myself if you decide to go through with my proposal :)
