Skip to content

Add filtering feature to report object #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 9, 2024
Merged

Add filtering feature to report object #122

merged 2 commits into from
Sep 9, 2024

Conversation

@margalva
Copy link
Collaborator

@margalva margalva commented Sep 8, 2024

Move the "filter string to url" to utils.
Add the filtering argument also for the report object.

@margalva margalva requested a review from phchen95 September 8, 2024 21:32
@margalva margalva enabled auto-merge (squash) September 8, 2024 22:26
phchen95
phchen95 approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@phchen95 phchen95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding the filter string @margalva, this will be helpful addition for the web component to fetch report!

@margalva margalva merged commit 36db6dd into main Sep 9, 2024
@margalva margalva deleted the feat/query_filter branch September 9, 2024 13:25
@margalva margalva mentioned this pull request Sep 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phchen95 phchen95 phchen95 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@margalva @phchen95